Fix handling of /EHsc and /MP flags #2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These flags are now specified via a generator expression, so they are only applied to C++ compilation, not CUDA. This also makes the flags PRIVATE, not PUBLIC. They should not affect dependant projects, so they should not be a part of the public interface. Resolves AcademySoftwareFoundation#2018 Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
merged commit 310e3bd
into
AcademySoftwareFoundation:main
28 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags are now specified via a generator expression, so they are only applied to C++ compilation, not CUDA.
This also makes the flags PRIVATE, not PUBLIC. They should not affect dependant projects, so they should not be a part of the public interface.
Resolves #2018