Fix bad pointer math #1977
Merged
Fix bad pointer math #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meshula
reviewed
Feb 11, 2025
In SSE, we were incrementing a pointer as if it were a uint16_t, not an si128, causing out of bounds accesses on non-block aligned chunks. Similarly, simplify the alignment logic and check return values and pointers in related accesses (non-block aligned linear lut lookup). Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
force-pushed
the
fix_dwa_buffer_read
branch
from
dd77634 to
c94c6ce
Compare
yes, we would need a proper test for dwa encoding using the non-linear encoding table code than just the default linear encoding and then compile with sse on x86 (although that should be the case). I don't know if we have a test image with that non-linear encoding to know what is "right"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SSE, we were incrementing a pointer as if it were a uint16_t, not an si128, causing out of bounds accesses on non-block aligned chunks.
Similarly, simplify the alignment logic and check return values and pointers in related accesses (non-block aligned linear lut lookup).