-
-
Notifications
You must be signed in to change notification settings - Fork 27
EAS build errors with react-native-datetimepicker #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fixed a long time ago. Just update Expo (even in latest v52) If another AppTheme is still created, the issue is in rn-datepicker |
Update: Issue is here: https://github.com/react-native-datetimepicker/datetimepicker/blob/4865e33a14e8faef65f4c83173b6a2223e53d5a3/plugin/src/withDateTimePickerStyles.ts#L87 This function is deprecated in Expo. They should use Feel free to open a PR on their repo. |
Thank you. I'm on v53. Could it be that in my case they are overwriting after edge-to-edge one is created? |
@BenGroot I published the fix to apply in |
I'll look further into it. Thanks for the amazingly quick reply. |
Reported at react-native-datetimepicker: Also included a workaround for in the meantime. |
Before submitting a new issue
Bug summary
A duplicate AppTheme is created in style.xml on Android when using react-native-datetimepicker with custom colors in combination with this package. This causes EAS build to fail.
Library version
1.6.0
Environment info
Steps to reproduce
Set a custom color for react-native-datetimepicker this way: https://github.com/react-native-datetimepicker/datetimepicker/blob/master/docs/android-styling.md
That creates an AppTheme in the style.xml.
Correct the theme for edge-to-edge support using: https://github.com/zoontek/react-native-edge-to-edge?tab=readme-ov-file#expo
Which also results in an AppTheme being created.
Build the combination and see the error
Reproducible sample code
The text was updated successfully, but these errors were encountered: