fix(pnp): resolve virtual paths in process.dlopen (#4630)

Author: merceyz

.pnp.cjs

@@ -0,0 +1,28 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-pnp": patch
+  "@yarnpkg/pnp": patch
+
+declined:
+  - "@yarnpkg/esbuild-plugin-pnp"
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/pnpify"
+  - "@yarnpkg/sdks"

.yarn/versions/c4427793.yml

@@ -1,4 +1,4 @@
-const {npath, ppath, xfs} = require(`@yarnpkg/fslib`);
+const {npath, ppath, xfs, Filename} = require(`@yarnpkg/fslib`);
 const cp = require(`child_process`);
 const {satisfies} = require(`semver`);
 
@@ -2097,4 +2097,33 @@ describe(`Plug'n'Play`, () => {
       },
     ),
   );
+
+  test(
+    `it should resolve virtual paths passed to process.dlopen`,
+    makeTemporaryEnv(
+      {
+        dependencies: {
+          pkg: `portal:./pkg`,
+        },
+      },
+      async ({path, run, source}) => {
+        await xfs.mkdirPromise(ppath.join(path, `pkg`));
+        await xfs.writeFilePromise(ppath.join(path, `pkg/test.node`), `invalid`);
+        await xfs.writeJsonPromise(ppath.join(path, `pkg`, Filename.manifest), {
+          name: `pkg`,
+          peerDependencies: {
+            'no-deps': `*`,
+          },
+        });
+
+        await expect(run(`install`)).resolves.toMatchObject({code: 0});
+
+        await expect(source(`require('pkg/test.node')`)).rejects.toMatchObject({
+          externalException: {
+            message: expect.not.stringMatching(/__virtual__|invalid mode/),
+          },
+        });
+      },
+    ),
+  );
 });

packages/acceptance-tests/pkg-tests-specs/sources/pnp.test.js

@@ -1,13 +1,13 @@
-import {FakeFS, PosixFS, npath, patchFs, PortablePath, NativePath} from '@yarnpkg/fslib';
-import fs                                                          from 'fs';
-import {Module}                                                    from 'module';
-import {URL, fileURLToPath}                                        from 'url';
+import {FakeFS, PosixFS, npath, patchFs, PortablePath, NativePath, VirtualFS} from '@yarnpkg/fslib';
+import fs                                                                     from 'fs';
+import {Module}                                                               from 'module';
+import {URL, fileURLToPath}                                                   from 'url';
 
-import {PnpApi}                                                    from '../types';
+import {PnpApi}                                                               from '../types';
 
-import {ErrorCode, makeError, getIssuerModule}                     from './internalTools';
-import {Manager}                                                   from './makeManager';
-import * as nodeUtils                                              from './nodeUtils';
+import {ErrorCode, makeError, getIssuerModule}                                from './internalTools';
+import {Manager}                                                              from './makeManager';
+import * as nodeUtils                                                         from './nodeUtils';
 
 export type ApplyPatchOptions = {
   fakeFs: FakeFS<PortablePath>;
@@ -19,6 +19,14 @@ type PatchedModule = Module & {
   isLoading?: boolean;
 };
 
+declare global {
+  module NodeJS {
+    interface Process {
+      dlopen: (module: Object, filename: string, flags?: number) => void;
+    }
+  }
+}
+
 export function applyPatch(pnpapi: PnpApi, opts: ApplyPatchOptions) {
   /**
    * The cache that will be used for all accesses occurring outside of a PnP context.
@@ -411,6 +419,17 @@ export function applyPatch(pnpapi: PnpApi, opts: ApplyPatchOptions) {
     originalExtensionJSFunction.call(this, module, filename);
   };
 
+  const originalDlopen = process.dlopen;
+  process.dlopen = function (...args) {
+    const [module, filename, ...rest] = args;
+    return originalDlopen.call(
+      this,
+      module,
+      npath.fromPortablePath(VirtualFS.resolveVirtual(npath.toPortablePath(filename))),
+      ...rest,
+    );
+  };
+
   // When using the ESM loader Node.js prints either of the following warnings
   //
   // - ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time