PHP 8.4

[sidewaysglance]

Hi,

Just wondering if there's anything interesting coming in PHP 8.4 as far as this wonderful library is concerned?

Cheers

[marcimat]

At least, there is a deprecated in PHP 8.4.0alpha4 here

htmlpurifier-html5/library/HTMLPurifier/HTML5Config.php

Line 65 in 0105fef

public function __construct(HTMLPurifier_ConfigSchema $schema, HTMLPurifier_PropertyList $parent = null)

Deprecated: HTMLPurifier_HTML5Config::__construct(): Implicitly marking parameter $parent as nullable is deprecated, the explicit nullable type must be used instead in [...]library/HTMLPurifier/HTML5Config.php on line 65

-    public function __construct(HTMLPurifier_ConfigSchema $schema, HTMLPurifier_PropertyList $parent = null)
+    public function __construct(HTMLPurifier_ConfigSchema $schema, ?HTMLPurifier_PropertyList $parent = null)

[xemlock]

Hi! Thanks for pointing that out. I'm planning on making the code PHP 8.4 compatible, as well as use new DOM parsing abilities provided by DOM\HTMLDocument.

[phppress]

It would be great to have a release with PHP 8.4 support initially, so we don't depend on master in stable projects.

[DmytroPolavis]

@xemlock Are there any plans to create a tag for those changes with PHP8.4 support?

[tg666]

@xemlock would it be possible to make a tag? ... thanks :))