Skip to content

Commit d9b0256

Browse files
change external controller
1 parent 4dcdb13 commit d9b0256

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/main/kotlin/com/softeno/template/sample/http/external/api/ExternalController.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,11 @@ class ExternalController(
1818
private val log = LogFactory.getLog(javaClass)
1919

2020
@GetMapping("/{id}")
21-
fun getExternalResource(@PathVariable id: String): ResponseEntity<String> {
21+
fun getExternalResource(@PathVariable id: String): ResponseEntity<SampleResponseDto> {
2222
val data = externalServiceClient.fetchExternalResource(id)
2323
log.info("External: Received $id, sending: ${data.toString()}")
24-
return ResponseEntity.ok(data)
24+
return ResponseEntity.ok(SampleResponseDto(data = data ?: "null"))
2525
}
26-
}
26+
}
27+
28+
data class SampleResponseDto(val data: String)

src/test/kotlin/com/softeno/template/app/IntegrationTest.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,11 @@ class ExternalControllerTest : BaseIntegrationTest(), ExternalApiAbility {
186186
.exchange()
187187
.expectStatus().isOk()
188188
.expectBody()
189-
.jsonPath("data").isEqualTo("1")
189+
.jsonPath("data").isEqualTo("""
190+
{
191+
"data": "1"
192+
}
193+
""".trimIndent())
190194
}
191195
}
192196

0 commit comments

Comments
 (0)