app lifecycle

Author: DanielZlotin

jsconfig.json

@@ -0,0 +1,9 @@
+{
+    "compilerOptions": {
+        "allowJs": true,
+        "allowSyntheticDefaultImports": true
+    },
+    "exclude": [
+        "node_modules"
+    ]
+}

lib/android/app/build.gradle

@@ -1,5 +1,6 @@
 apply plugin: 'com.android.library'
 apply from: '../prepare-robolectric.gradle'
+apply plugin: 'jacoco'
 
 android {
     compileSdkVersion 25
@@ -40,10 +41,32 @@ android {
                     println "see report at file://${t.reports.html.destination}/index.html"
                 }
             }
+            jacoco {
+                includeNoLocationClasses = true
+            }
         }
     }
 }
 
+task unitTest(type: JacocoReport, dependsOn: 'testDebugUnitTest') {
+    reports {
+        xml.enabled = false
+        html.enabled = true
+    }
+
+    def fileFilter = ['**/R.class', '**/R$*.class', '**/BuildConfig.*', '**/Manifest*.*', '**/*Test*.*', 'android/**/*.*']
+    def debugTree = fileTree(dir: "${buildDir}/intermediates/classes/debug", excludes: fileFilter)
+    def mainSrc = "${project.projectDir}/src/main/java"
+
+    sourceDirectories = files([mainSrc])
+    classDirectories = files([debugTree])
+    executionData = files("${buildDir}/jacoco/testDebugUnitTest.exec")
+
+    doLast {
+        println "See code coverage at file://${jacoco.reportsDir}/unitTest/html/index.html"
+    }
+}
+
 dependencies {
     compile fileTree(include: ['*.jar'], dir: 'libs')
     compile 'com.android.support:design:25.1.1'

lib/android/app/src/main/java/com/reactnativenavigation/NavigationActivity.java

@@ -1,5 +1,6 @@
 package com.reactnativenavigation;
 
+import android.os.Bundle;
 import android.support.annotation.Nullable;
 import android.support.v7.app.AppCompatActivity;
 import android.view.View;
@@ -9,6 +10,30 @@
 public class NavigationActivity extends AppCompatActivity implements DefaultHardwareBackBtnHandler {
 	private View contentView;
 
+	@Override
+	protected void onCreate(@Nullable Bundle savedInstanceState) {
+		super.onCreate(savedInstanceState);
+		NavigationApplication.instance.getConfig().activityLifecycleDelegate.onActivityCreated(this);
+	}
+
+	@Override
+	protected void onResume() {
+		super.onResume();
+		NavigationApplication.instance.getConfig().activityLifecycleDelegate.onActivityResumed(this, this);
+	}
+
+	@Override
+	protected void onPause() {
+		super.onPause();
+		NavigationApplication.instance.getConfig().activityLifecycleDelegate.onActivityPaused(this);
+	}
+
+	@Override
+	protected void onDestroy() {
+		super.onDestroy();
+		NavigationApplication.instance.getConfig().activityLifecycleDelegate.onActivityDestroyed(this);
+	}
+
 	@Override
 	public void setContentView(View contentView) {
 		super.setContentView(contentView);

lib/android/app/src/main/java/com/reactnativenavigation/NavigationApplication.java

@@ -1,12 +1,9 @@
 package com.reactnativenavigation;
 
-import android.app.Activity;
 import android.app.Application;
-import android.os.Bundle;
 
 import com.facebook.react.ReactApplication;
 import com.facebook.react.ReactNativeHost;
-import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
 import com.reactnativenavigation.controllers.ActivityLifecycleDelegate;
 import com.reactnativenavigation.react.DevPermissionRequestImpl;
 import com.reactnativenavigation.react.NavigationReactNativeHost;
@@ -26,43 +23,6 @@ public void onCreate() {
 		super.onCreate();
 		instance = this;
 		config = createConfig();
-
-		registerActivityLifecycleCallbacks(new ActivityLifecycleCallbacks() {
-			@Override
-			public void onActivityCreated(Activity activity, Bundle savedInstanceState) {
-				getConfig().activityLifecycleDelegate.onActivityCreated(activity);
-			}
-
-			@Override
-			public void onActivityStarted(Activity activity) {
-
-			}
-
-			@Override
-			public void onActivityResumed(Activity activity) {
-				getConfig().activityLifecycleDelegate.onActivityResumed(activity, (DefaultHardwareBackBtnHandler) activity);
-			}
-
-			@Override
-			public void onActivityPaused(Activity activity) {
-				getConfig().activityLifecycleDelegate.onActivityPaused(activity);
-			}
-
-			@Override
-			public void onActivityStopped(Activity activity) {
-
-			}
-
-			@Override
-			public void onActivitySaveInstanceState(Activity activity, Bundle outState) {
-
-			}
-
-			@Override
-			public void onActivityDestroyed(Activity activity) {
-				getConfig().activityLifecycleDelegate.onActivityDestroyed(activity);
-			}
-		});
 	}
 
 	public final Config getConfig() {

lib/android/app/src/test/java/com/reactnativenavigation/NavigationActivityTest.java

@@ -2,14 +2,22 @@
 
 import android.view.View;
 
+import com.reactnativenavigation.controllers.ActivityLifecycleDelegate;
+
 import org.junit.Test;
 import org.robolectric.Robolectric;
 import org.robolectric.android.controller.ActivityController;
 
 import static org.assertj.core.api.Java6Assertions.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
+import static org.mockito.Mockito.verifyZeroInteractions;
 
 public class NavigationActivityTest extends BaseTest {
 
+
 	@Test
 	public void holdsContentView() throws Exception {
 		NavigationActivity activity = Robolectric.setupActivity(NavigationActivity.class);
@@ -22,6 +30,25 @@ public void holdsContentView() throws Exception {
 	@Test
 	public void reportsLifecycleEventsToDelegate() throws Exception {
 		ActivityController<NavigationActivity> activityController = Robolectric.buildActivity(NavigationActivity.class);
+		NavigationApplication.instance.getConfig().activityLifecycleDelegate = mock(ActivityLifecycleDelegate.class);
+		ActivityLifecycleDelegate activityLifecycleDelegate = NavigationApplication.instance.getConfig().activityLifecycleDelegate;
+
+		verifyZeroInteractions(activityLifecycleDelegate);
+
 		activityController.create();
+		verify(activityLifecycleDelegate, times(1)).onActivityCreated(activityController.get());
+		verifyNoMoreInteractions(activityLifecycleDelegate);
+
+		activityController.resume();
+		verify(activityLifecycleDelegate, times(1)).onActivityResumed(activityController.get(), activityController.get());
+		verifyNoMoreInteractions(activityLifecycleDelegate);
+
+		activityController.pause();
+		verify(activityLifecycleDelegate, times(1)).onActivityPaused(activityController.get());
+		verifyNoMoreInteractions(activityLifecycleDelegate);
+
+		activityController.destroy();
+		verify(activityLifecycleDelegate, times(1)).onActivityDestroyed(activityController.get());
+		verifyNoMoreInteractions(activityLifecycleDelegate);
 	}
-}
+}

lib/android/app/src/test/java/com/reactnativenavigation/controllers/NavigationActivityLifecycleHandlerTest.java

@@ -17,4 +17,4 @@
 # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
 # org.gradle.parallel=true
 
-android.useDeprecatedNdk=true
+android.useDeprecatedNdk=false

playground/android/gradle.properties

@@ -2,5 +2,5 @@ const exec = require('shell-utils').exec;
 run();
 
 function run() {
-  exec.execSync(`cd lib/android && ./gradlew clean testDebugUnitTest`);
+  exec.execSync(`cd lib/android && ./gradlew clean unitTest`);
 }