Skip to content

pools are not closed if errors are thrown #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jedwards1211 opened this issue Jan 6, 2019 · 0 comments · May be fixed by #4
Open

pools are not closed if errors are thrown #3

jedwards1211 opened this issue Jan 6, 2019 · 0 comments · May be fixed by #4

Comments

@jedwards1211
Copy link

For example, at https://github.com/sikanrong/umzug-postgres-storage/blob/master/src/umzug-postgres-storage.js#L34:

The .then() callback will get called and close the pool if the query completes successfully. But if the query fails, the promise will reject instead of resolve, and the callback to close the pool will never get called.
jedwards1211 added a commit to jedwards1211/umzug-postgres-storage that referenced this issue Jan 6, 2019
@jedwards1211
fix: also close pool when queries fail
e549661 
fix windfish-studio#3
@jedwards1211 jedwards1211 linked a pull request Jan 6, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: also close pool when queries fail jedwards1211/umzug-postgres-storage
1 participant
@jedwards1211