chore: add more tracing data (#9994)

Author: hardfist

.gitignore

@@ -234,4 +234,7 @@ diff_output
 /website/doc_build
 
 # xcode trace
-*.trace
+*.trace
+
+# rspack trace file
+trace.json

.vscode/settings.json

@@ -21,6 +21,7 @@
   "rust-analyzer.linkedProjects": [
     "Cargo.toml"
   ],
+  "rust-analyzer.cargo.features": ["rspack_cacheable/noop"],
   "files.associations": {
     "*.snap": "markdown",
     "*.snap.txt": "markdown",

crates/rspack_core/src/chunk_graph/chunk_graph_module.rs

@@ -283,7 +283,7 @@ impl ChunkGraph {
       .map(|cgm| &cgm.chunks)
   }
 
-  #[instrument("chunk_graph:get_module_graph_hash", skip_all, fields(module = ?module.identifier()))]
+  #[instrument("chunk_graph:get_module_graph_hash", level="trace",skip_all, fields(module = ?module.identifier()))]
   pub fn get_module_graph_hash(
     &self,
     module: &dyn Module,

crates/rspack_core/src/compiler/compilation.rs

@@ -1408,6 +1408,7 @@ impl Compilation {
         .compilation_hooks
         .optimize_dependencies
         .call(self)
+        .instrument(info_span!("Compilation:optimize_dependencies"))
         .await?,
       Some(true)
     ) {}
@@ -1445,10 +1446,8 @@ impl Compilation {
       .instrument(info_span!("Compilation:after_optimize_modules"))
       .await?;
     while matches!(
-      plugin_driver
-        .compilation_hooks
-        .optimize_chunks
-        .call(self)
+      tracing::info_span!("Compilation:optimize_chunks")
+        .in_scope(|| { plugin_driver.compilation_hooks.optimize_chunks.call(self) })
         .await?,
       Some(true)
     ) {}

crates/rspack_core/src/compiler/mod.rs

@@ -93,7 +93,6 @@ pub struct Compiler {
 }
 
 impl Compiler {
-  #[instrument(skip_all)]
   #[allow(clippy::too_many_arguments)]
   pub fn new(
     compiler_path: String,

crates/rspack_core/src/normal_module.rs

@@ -277,7 +277,7 @@ impl NormalModule {
     &mut self.presentational_dependencies
   }
 
-  #[tracing::instrument("NormalModule:build_hash")]
+  #[tracing::instrument("NormalModule:build_hash", skip_all)]
   fn init_build_hash(
     &self,
     output_options: &OutputOptions,

crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs

@@ -833,7 +833,7 @@ fn do_optimize_connection(
   (dependency, target_module)
 }
 
-#[tracing::instrument(skip_all)]
+#[tracing::instrument("can_optimize_connection", level = "trace", skip_all)]
 fn can_optimize_connection(
   connection: &ModuleGraphConnection,
   side_effects_state_map: &IdentifierMap<ConnectionState>,

crates/rspack_plugin_swc_js_minimizer/src/lib.rs

@@ -170,11 +170,12 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
       Regex::new(condition)
         .unwrap_or_else(|_| panic!("`{condition}` is invalid extractComments condition"))
     });
-
+  let enter_span = tracing::Span::current();
   compilation
     .assets_mut()
     .par_iter_mut()
     .filter(|(filename, original)| {
+      // propagate span in rayon to keep parent relation
       if !JAVASCRIPT_ASSET_REGEXP.is_match(filename) {
         return false
       }
@@ -188,6 +189,7 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
       true
     })
     .try_for_each_with(tx,|tx, (filename, original)| -> Result<()>  {
+      let _guard = enter_span.enter();
       let filename = filename.split('?').next().expect("Should have filename");
       if let Some(original_source) = original.get_source() {
         let input = original_source.source().to_string();
@@ -279,7 +281,6 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
 
       Ok(())
   })?;
-
   compilation.extend_diagnostics(rx.into_iter().flatten().collect::<Vec<_>>());
 
   // write all extracted comments to assets

crates/rspack_plugin_swc_js_minimizer/src/minify.rs

@@ -40,6 +40,7 @@ use swc_ecma_minifier::{
   self,
   option::{MinifyOptions, TopLevelOptions},
 };
+use tracing::instrument;
 
 use crate::{JsMinifyOptions, NormalizedExtractComments, PluginOptions};
 
@@ -62,6 +63,7 @@ pub fn match_object(obj: &PluginOptions, str: &str) -> bool {
   true
 }
 
+#[instrument("swc_js_minify",skip_all, fields(filename=filename))]
 pub fn minify(
   opts: &JsMinifyOptions,
   input: String,

crates/rspack_tracing/src/chrome.rs

@@ -42,6 +42,6 @@ impl<S> Filter<S> for FilterEvent {
     _cx: &tracing_subscriber::layer::Context<'_, S>,
   ) -> bool {
     // filter out swc related tracing because it's too much noisy for info level now
-    !meta.is_event() && !meta.target().contains("swc")
+    !meta.is_event() && !meta.target().starts_with("swc")
   }
 }