Skip to content

Commit 855af65

Browse files
authored
fix(react-native): makes options optional for RN firebase context (#56)
1 parent 22b4c84 commit 855af65

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

react-native/context/FirebaseContextProvider.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,14 @@ export type FirebaseContextProviderEmulators = {
6767
* @inline
6868
*/
6969
export type FirebaseContextProviderProps = PropsWithChildren & {
70-
platform: "Web" | "ReactNative";
7170
/**
7271
* Defines configuration for firebase emulators
7372
*/
7473
emulators?: FirebaseContextProviderEmulators;
7574
/**
7675
* Configuration options for Firebase initialization. {@link https://firebase.google.com/docs/web/setup#config-object | Learn about the Firebase config object}
7776
*/
78-
options: ReactNativeFirebase.FirebaseAppOptions;
77+
options?: ReactNativeFirebase.FirebaseAppOptions;
7978
/**
8079
* Flag indicating whether Firebase Auth should be enabled.
8180
*/
@@ -151,7 +150,6 @@ export type FirebaseContextProviderProps = PropsWithChildren & {
151150
*/
152151
export const FirebaseContextProvider: React.FC<FirebaseContextProviderProps> = ({
153152
emulators,
154-
options,
155153
children,
156154
authEnabled = true,
157155
firestoreEnabled = true,
@@ -211,11 +209,11 @@ export const FirebaseContextProvider: React.FC<FirebaseContextProviderProps> = (
211209
}, [emulators?.auth, authEnabled, internalFirebase]);
212210

213211
const internalAnalytics = useMemo(() => {
214-
if (analyticsEnabled && options.measurementId) {
212+
if (analyticsEnabled) {
215213
return internalFirebase.analytics();
216214
}
217215
return null;
218-
}, [analyticsEnabled, options.measurementId, internalFirebase]);
216+
}, [analyticsEnabled, internalFirebase]);
219217

220218
const internalRemoteConfig = useMemo(() => {
221219
if (remoteConfigEnabled) {

0 commit comments

Comments
 (0)