Merge pull request joshsoftware#152 from BandanaPandey/webmock_test

refs joshsoftware#149 Added delete button on admin users page.

Author: sethu

Gemfile.lock

@@ -420,4 +420,4 @@ RUBY VERSION
    ruby 2.3.0p0
 
 BUNDLED WITH
-   1.12.5
+   1.12.5

app/controllers/admin/users_controller.rb

@@ -33,4 +33,17 @@ def search
 
     render :index
   end
+
+  def destroy
+    user = User.find(params[:id])
+
+    if user
+      user.destroy
+      redirect_to admin_users_path, notice: "#{user.name} has been deleted successfully"
+    else
+      redirect_to admin_users_path, notice: "User not found"
+    end
+    
+  end
+
 end

app/models/user.rb

@@ -53,20 +53,20 @@ class User
   field :last_repo_sync_at,  type: Time
   field :last_gh_data_sync_at, type: Time
 
+  belongs_to :goal
   has_many :commits, dependent: :destroy
   has_many :activities, dependent: :destroy
+  has_many :transactions, dependent: :destroy
+  has_many :subscriptions, dependent: :destroy
+  has_many :rounds
+  has_many :comments, dependent: :destroy
+  has_many :redeem_requests, dependent: :destroy
+  has_many :group_invitations, dependent: :destroy
   has_and_belongs_to_many :repositories, class_name: 'Repository', inverse_of: 'users'
   has_and_belongs_to_many :judges_repositories, class_name: 'Repository', inverse_of: 'judges'
   has_and_belongs_to_many :roles, inverse_of: nil
-  has_many :transactions
-  has_many :subscriptions
-  has_many :rounds
-  has_many :comments
   has_and_belongs_to_many :organizations
-  has_and_belongs_to_many :groups, class_name: 'Group', inverse_of: 'members'
-  has_many :redeem_requests
-  has_many :group_invitations
-  belongs_to :goal
+  has_and_belongs_to_many :groups, class_name: 'Group', inverse_of: 'members' 
 
   slug  :github_handle
 

app/views/admin/users/_user.html.haml

@@ -16,3 +16,5 @@
     %a{href: admin_user_login_as_path(user), class: "btn btn-primary btn-sm", data: {confirm: "Are you sure?"}}
       %i.fa.fa-user
       Login as
+    %a{href: admin_user_path(user.id), class: "btn btn-danger btn-sm", data: {method: 'delete', confirm: "Are you sure? This action is irreversible"}}
+      %i.fa.fa-trash

config/routes.rb

@@ -39,7 +39,7 @@
         get :assign_judge
       end
     end
-    resources :users, only: [:index] do
+    resources :users, only: [:index, :destroy] do
       get :mark_as_judge
       get :login_as
       get :search, on: :collection

test/controllers/admin/users_controller_test.rb

@@ -0,0 +1,43 @@
+require "test_helper"
+
+class Admin::UsersControllerTest < ActionController::TestCase
+
+  def setup
+    super
+    @admin_role = create :role, :admin
+    @goal = create :goal, points: 15
+    @round = create :round, :open
+    @user = create :user, auth_token: 'dah123rty', goal: @goal
+  end
+
+  test 'should not access index if the current user is non-admin' do
+    sign_in @user
+    get :index
+    assert_response :redirect
+  end
+
+  test 'should access users index only if the user is admin' do
+    @user.roles << @admin_role
+    sign_in @user
+    other_user = create :user, auth_token: Faker::Lorem.word, goal: @goal
+    assert_equal User.count, 2
+    get :index
+    assert_response :success
+  end
+
+  test 'should destroy all associations of the user on destroying any user by admin' do
+    @user.roles << @admin_role
+    sign_in @user
+    other_user = create :user, auth_token: 'dah123rty', goal: @goal
+    assert_equal other_user.transactions.count, 0
+    transaction = create_list :transaction, 3, type: 'credit', user: other_user
+    assert_equal other_user.transactions.count, 3
+    redeem_request = create :redeem_request, points: 2, user: other_user
+    assert_equal other_user.transactions.count, 4
+    delete :destroy, id: other_user.id
+    assert_equal Transaction.count, 0
+    assert_equal RedeemRequest.count, 0
+    assert_response :redirect
+  end
+
+end