feat: added new outputs app_config_account_id, app_config_crn and app_config_account_id (#206)

Author: ocofaigh

README.md

@@ -111,8 +111,11 @@ For more information on access and permissions, see <https://cloud.ibm.com/docs/
 
 | Name | Description |
 |------|-------------|
+| <a name="output_app_config_account_id"></a> [app\_config\_account\_id](#output\_app\_config\_account\_id) | Account ID of the App Configuration instance |
 | <a name="output_app_config_collection_ids"></a> [app\_config\_collection\_ids](#output\_app\_config\_collection\_ids) | List of IDs for the collections in the App Configuration instance |
+| <a name="output_app_config_crn"></a> [app\_config\_crn](#output\_app\_config\_crn) | CRN of the App Configuration instance |
 | <a name="output_app_config_guid"></a> [app\_config\_guid](#output\_app\_config\_guid) | GUID of the App Configuration instance |
+| <a name="output_app_config_id"></a> [app\_config\_id](#output\_app\_config\_id) | ID of the App Configuration instance |
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 
 <!-- Leave this section as is so that your module has a link to local development environment set up steps for contributors to follow -->

examples/basic/outputs.tf

@@ -16,3 +16,18 @@ output "app_config_guid" {
   description = "App Configuration GUID"
   value       = module.app_config.app_config_guid
 }
+
+output "app_config_crn" {
+  description = "CRN of the App Configuration instance"
+  value       = module.app_config.app_config_crn
+}
+
+output "app_config_id" {
+  description = "ID of the App Configuration instance"
+  value       = module.app_config.app_config_id
+}
+
+output "app_config_account_id" {
+  description = "Account ID of the App Configuration instance"
+  value       = module.app_config.app_config_account_id
+}

examples/complete/outputs.tf

@@ -14,14 +14,29 @@ output "prefix" {
 
 output "resource_group_name" {
   description = "The name of the resource group used"
-  value       = var.resource_group
+  value       = module.resource_group.resource_group_name
 }
 
 output "app_config_guid" {
   description = "App Configuration GUID"
   value       = module.app_config.app_config_guid
 }
 
+output "app_config_crn" {
+  description = "CRN of the App Configuration instance"
+  value       = module.app_config.app_config_crn
+}
+
+output "app_config_id" {
+  description = "ID of the App Configuration instance"
+  value       = module.app_config.app_config_id
+}
+
+output "app_config_account_id" {
+  description = "Account ID of the App Configuration instance"
+  value       = module.app_config.app_config_account_id
+}
+
 output "app_config_collection_ids" {
   description = "App Configuration Collection IDs"
   value       = module.app_config.app_config_collection_ids

outputs.tf

@@ -2,11 +2,26 @@
 # Outputs
 ########################################################################################################################
 
+output "app_config_crn" {
+  description = "CRN of the App Configuration instance"
+  value       = ibm_resource_instance.app_config.crn
+}
+
+output "app_config_id" {
+  description = "ID of the App Configuration instance"
+  value       = ibm_resource_instance.app_config.id
+}
+
 output "app_config_guid" {
   description = "GUID of the App Configuration instance"
   value       = ibm_resource_instance.app_config.guid
 }
 
+output "app_config_account_id" {
+  description = "Account ID of the App Configuration instance"
+  value       = ibm_resource_instance.app_config.account_id
+}
+
 output "app_config_collection_ids" {
   description = "List of IDs for the collections in the App Configuration instance"
   value       = [for obj in ibm_app_config_collection.collections : obj.collection_id]

tests/pr_test.go

@@ -11,7 +11,6 @@ import (
 )
 
 // Use existing resource group
-const resourceGroup = "geretain-test-app-config"
 const completeExampleDir = "examples/complete"
 
 func setupOptions(t *testing.T, prefix string, dir string) *testhelper.TestOptions {
@@ -23,11 +22,10 @@ func setupOptions(t *testing.T, prefix string, dir string) *testhelper.TestOptio
 	}
 	rand.New(rand.NewSource(time.Now().Unix()))
 	options := testhelper.TestOptionsDefaultWithVars(&testhelper.TestOptions{
-		Testing:       t,
-		TerraformDir:  dir,
-		Prefix:        prefix,
-		Region:        validRegions[rand.Intn(len(validRegions))],
-		ResourceGroup: resourceGroup,
+		Testing:      t,
+		TerraformDir: dir,
+		Prefix:       prefix,
+		Region:       validRegions[rand.Intn(len(validRegions))],
 	})
 	return options
 }