Skip to content

Commit e792391

Browse files
committed
Removes duplicate style specs.
Angular v15, which is the one currently used in the OSS repo, uses styles with format `--mdc-` to style material components. Later versions of angular migrated to a `--mat-` prefix, and Angular v20 will update some of the names again. Our internal codebase uses the styles defined internally, so we need to use the new format. We recently set up translations internally from these "old" `--mdc-` stylings to the newer `--mat-` names, so we don't need them duplicate here, which could potentially be a source for confusion.
1 parent f95d28d commit e792391

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/timeline/timeline_component.css

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,8 @@ limitations under the License.
6666
position: absolute;
6767
right: 40px;
6868
--mdc-slider-handle-width: 80px;
69-
--mat-slider-handle-width: 80px;
7069
--mdc-slider-handle-height: 16px;
71-
--mat-slider-handle-height: 16px;
7270
--mdc-slider-handle-shape: 5px;
73-
--mat-slider-handle-shape: 5px;
7471
}
7572

7673
::ng-deep .mat-mdc-focus-indicator {

tensorboard/webapp/theme/_tb_theme.template.scss

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -303,13 +303,9 @@ $tb-dark-theme: map_merge(
303303
body.dark-mode {
304304
mat-slider {
305305
--mdc-slider-handle-width: 12px;
306-
--mat-slider-handle-width: 12px;
307306
--mdc-slider-handle-height: 12px;
308-
--mat-slider-handle-height: 12px;
309307
--mdc-slider-active-track-height: 2px;
310-
--mat-slider-active-track-height: 2px;
311308
--mdc-slider-inactive-track-height: 2px;
312-
--mat-slider-inactive-track-height: 2px;
313309
}
314310

315311
a,
@@ -319,13 +315,9 @@ $tb-dark-theme: map_merge(
319315
--tb-icon-button-width: 40px;
320316
--tb-icon-button-height: 40px;
321317
--mdc-text-button-label-text-tracking: normal;
322-
--mat-text-button-label-text-tracking: normal;
323318
--mdc-filled-button-label-text-tracking: normal;
324-
--mat-filled-button-label-text-tracking: normal;
325319
--mdc-outlined-button-label-text-tracking: normal;
326-
--mat-outlined-button-label-text-tracking: normal;
327320
--mdc-protected-button-label-text-tracking: normal;
328-
--mat-protected-button-label-text-tracking: normal;
329321

330322
&[mat-icon-button].mat-mdc-icon-button {
331323
width: var(--tb-icon-button-width);

0 commit comments

Comments
 (0)