Skip to content

Commit 52530fa

Browse files
authored
Explicitly set standalone for all Angular components (#6912)
Angular v19 is going to change the default value for `standalone` from `false` to `true`. Even though tensorboard is on an older version of Angular on GitHub, the version inside Google runs at HEAD. We're in the process of changing existing code in google to explicitly set `standalone: false` for existing code, so I'm sending this change to the source of truth here.
1 parent da1833f commit 52530fa

File tree

177 files changed

+197
-0
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

177 files changed

+197
-0
lines changed

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {ChangeDetectionStrategy, Component, Input} from '@angular/core';
1616
import {DebuggerRunListing} from './store/debugger_types';
1717

1818
@Component({
19+
standalone: false,
1920
selector: 'debugger-component',
2021
templateUrl: './debugger_component.ng.html',
2122
styleUrls: ['./debugger_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {getActiveRunId, getDebuggerRunListing} from './store';
1919
import {State} from './store/debugger_types';
2020

2121
@Component({
22+
standalone: false,
2223
selector: 'tf-debugger-v2',
2324
template: `
2425
<debugger-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/testing/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ export function createState(
354354
// that use it.
355355

356356
@Component({
357+
standalone: false,
357358
selector: 'tf-debugger-v2',
358359
template: ``,
359360
})

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/alerts/alerts_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export interface AlertTypeDisplay {
2323
}
2424

2525
@Component({
26+
standalone: false,
2627
selector: 'alerts-component',
2728
templateUrl: './alerts_component.ng.html',
2829
styleUrls: ['./alerts_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/alerts/alerts_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ const ALERT_TYPE_TO_DISPLAY_NAME_AND_SYMBOL: {
4545
};
4646

4747
@Component({
48+
standalone: false,
4849
selector: 'tf-debugger-v2-alerts',
4950
template: `
5051
<alerts-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/debug_tensor_value/debug_tensor_value_component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const basicDebugInfoStyle = `
3030
`;
3131

3232
@Component({
33+
standalone: false,
3334
selector: 'debug-tensor-dtype',
3435
template: ` {{ dtype }} `,
3536
styles: [basicDebugInfoStyle],
@@ -40,6 +41,7 @@ export class DebugTensorDTypeComponent {
4041
}
4142

4243
@Component({
44+
standalone: false,
4345
selector: 'debug-tensor-rank',
4446
template: ` {{ rank }}D `,
4547
styles: [basicDebugInfoStyle],
@@ -50,6 +52,7 @@ export class DebugTensorRankComponent {
5052
}
5153

5254
@Component({
55+
standalone: false,
5356
selector: 'debug-tensor-shape',
5457
template: ` shape:{{ shapeString }} `,
5558
styles: [basicDebugInfoStyle],
@@ -72,6 +75,7 @@ export class DebugTensorShapeComponent {
7275
}
7376

7477
@Component({
78+
standalone: false,
7579
selector: 'debug-tensor-numeric-breakdown',
7680
template: `
7781
<div class="size">
@@ -205,6 +209,7 @@ export class DebugTensorNumericBreakdownComponent {
205209
}
206210

207211
@Component({
212+
standalone: false,
208213
selector: 'debug-tensor-has-inf-or-nan',
209214
template: `
210215
<div [ngClass]="['container', hasInfOrNaN ? 'has-inf-or-nan' : '']">
@@ -242,6 +247,7 @@ export class DebugTensorHasInfOrNaNComponent {
242247
}
243248

244249
@Component({
250+
standalone: false,
245251
selector: 'debug-tensor-value',
246252
template: `
247253
<debug-tensor-dtype

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/execution_data_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {Execution, TensorDebugMode} from '../../store/debugger_types';
1717
import {parseDebugTensorValue} from '../../store/debug_tensor_value';
1818

1919
@Component({
20+
standalone: false,
2021
selector: 'execution-data-component',
2122
templateUrl: './execution_data_component.ng.html',
2223
styleUrls: ['./execution_data_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/execution_data_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import {DTYPE_ENUM_TO_NAME} from '../../tf_dtypes';
2121
const UNKNOWN_DTYPE_NAME = 'Unknown dtype';
2222

2323
@Component({
24+
standalone: false,
2425
selector: 'tf-debugger-v2-execution-data',
2526
template: `
2627
<execution-data-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/graph_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import {
2727
} from '../../store/debugger_types';
2828

2929
@Component({
30+
standalone: false,
3031
selector: 'graph-component',
3132
templateUrl: './graph_component.ng.html',
3233
styleUrls: ['./graph_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/graph_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
import {State} from '../../store/debugger_types';
2424

2525
@Component({
26+
standalone: false,
2627
selector: 'tf-debugger-v2-graph',
2728
template: `
2829
<graph-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/graph_op_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {Component, EventEmitter, Input, Output} from '@angular/core';
1717
import {GraphOpInfo} from '../../store/debugger_types';
1818

1919
@Component({
20+
standalone: false,
2021
selector: 'graph-op',
2122
templateUrl: 'graph_op_component.ng.html',
2223
styleUrls: ['./graph_op_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/graph_executions_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import {GraphExecution} from '../../store/debugger_types';
2828
import {parseDebugTensorValue} from '../../store/debug_tensor_value';
2929

3030
@Component({
31+
standalone: false,
3132
selector: 'graph-executions-component',
3233
templateUrl: './graph_executions_component.ng.html',
3334
styleUrls: ['./graph_executions_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph_executions/graph_executions_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import {
2727
import {State} from '../../store/debugger_types';
2828

2929
@Component({
30+
standalone: false,
3031
selector: 'tf-debugger-v2-graph-executions',
3132
template: `
3233
<graph-executions-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/inactive/inactive_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ limitations under the License.
1515
import {Component} from '@angular/core';
1616

1717
@Component({
18+
standalone: false,
1819
selector: 'inactive-component',
1920
templateUrl: './inactive_component.ng.html',
2021
styleUrls: ['./inactive_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/inactive/inactive_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {Store} from '@ngrx/store';
1919
export interface InactiveState {}
2020

2121
@Component({
22+
standalone: false,
2223
selector: 'tf-debugger-v2-inactive',
2324
template: ` <inactive-component></inactive-component> `,
2425
})

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {SourceFileContent, StackFrame} from '../../store/debugger_types';
2424
* displayed by this component.
2525
*/
2626
@Component({
27+
standalone: false,
2728
selector: 'source-files-component',
2829
templateUrl: './source_files_component.ng.html',
2930
styleUrls: ['./source_files_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/source_files/source_files_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
import {State as DebuggerState} from '../../store/debugger_types';
2525

2626
@Component({
27+
standalone: false,
2728
selector: 'tf-debugger-v2-source-files',
2829
template: `
2930
<source-files-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/stack_trace_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export interface StackFrameForDisplay {
4040
}
4141

4242
@Component({
43+
standalone: false,
4344
selector: 'stack-trace-component',
4445
templateUrl: './stack_trace_component.ng.html',
4546
styleUrls: ['./stack_trace_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/stack_trace_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import {CodeLocationType, State} from '../../store/debugger_types';
2525
import {StackFrameForDisplay} from './stack_trace_component';
2626

2727
@Component({
28+
standalone: false,
2829
selector: 'tf-debugger-v2-stack-trace',
2930
template: `
3031
<stack-trace-component

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/timeline/timeline_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export interface ExecutionDigestForDisplay {
3131
}
3232

3333
@Component({
34+
standalone: false,
3435
selector: 'timeline-component',
3536
templateUrl: './timeline_component.ng.html',
3637
styleUrls: ['./timeline_component.css'],

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/timeline/timeline_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ function getExecutionDigestForDisplay(
8585
}
8686

8787
@Component({
88+
standalone: false,
8889
selector: 'tf-debugger-v2-timeline',
8990
template: `
9091
<timeline-component

tensorboard/webapp/alert/views/alert_display_snackbar_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {splitByURL} from '../../util/string';
2020
import {AlertInfo} from '../types';
2121

2222
@Component({
23+
standalone: false,
2324
selector: 'alert-display-snackbar',
2425
templateUrl: './alert_display_snackbar_container.ng.html',
2526
styleUrls: ['./alert_display_snackbar_container.css'],

tensorboard/webapp/alert/views/alert_snackbar_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import {AlertDisplaySnackbarContainer} from './alert_display_snackbar_container'
3131
* Renders alerts in a 'snackbar' to indicate them to the user.
3232
*/
3333
@Component({
34+
standalone: false,
3435
selector: 'alert-snackbar',
3536
template: '',
3637
changeDetection: ChangeDetectionStrategy.OnPush,

tensorboard/webapp/app_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ limitations under the License.
1515
import {Component, ViewContainerRef} from '@angular/core';
1616

1717
@Component({
18+
standalone: false,
1819
selector: 'tb-webapp',
1920
templateUrl: './app_container.ng.html',
2021
styleUrls: ['./app_container.css'],

tensorboard/webapp/app_routing/route_registry_module_test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,21 @@ import {RouteRegistryModule} from './route_registry_module';
1919
import {RouteKind} from './types';
2020

2121
@Component({
22+
standalone: false,
2223
selector: 'experiment',
2324
template: 'I am experiment',
2425
})
2526
class Experiment {}
2627

2728
@Component({
29+
standalone: false,
2830
selector: 'experiments',
2931
template: 'List of experiment',
3032
})
3133
class Experiments {}
3234

3335
@Component({
36+
standalone: false,
3437
selector: 'not_found',
3538
template: 'Unknown route',
3639
})

tensorboard/webapp/app_routing/views/router_link_test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import {LocationModule} from '../location_module';
2727
import {RouterLinkDirectiveContainer} from './router_link_directive_container';
2828

2929
@Component({
30+
standalone: false,
3031
selector: 'test',
3132
template: '<a [routerLink]="link">testable link</a>',
3233
})
@@ -36,6 +37,7 @@ class TestableComponent {
3637
}
3738

3839
@Component({
40+
standalone: false,
3941
selector: 'test-with-reset',
4042
template:
4143
'<a [routerLink]="link" [resetNamespacedState]="resetNamespacedState">testable link</a>',

tensorboard/webapp/app_routing/views/router_outlet_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
} from '@angular/core';
2525

2626
@Component({
27+
standalone: false,
2728
selector: 'router-outlet-component',
2829
template: ` <ng-container #routeContainer></ng-container> `,
2930
changeDetection: ChangeDetectionStrategy.OnPush,

tensorboard/webapp/app_routing/views/router_outlet_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import {
2525
} from '../store/app_routing_selectors';
2626

2727
@Component({
28+
standalone: false,
2829
selector: 'router-outlet',
2930
template: `
3031
<router-outlet-component

tensorboard/webapp/app_routing/views/router_outlet_test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,14 @@ import {RouterOutletComponent} from './router_outlet_component';
3333
import {RouterOutletContainer} from './router_outlet_container';
3434

3535
@Component({
36+
standalone: false,
3637
selector: 'first',
3738
template: 'I am a test',
3839
})
3940
class FirstTestableComponent {}
4041

4142
@Component({
43+
standalone: false,
4244
selector: 'second',
4345
template: 'I am inevitable',
4446
})

tensorboard/webapp/core/views/dark_mode_supporter_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {State} from '../../app_state';
1818
import {getDarkModeEnabled} from '../../selectors';
1919

2020
@Component({
21+
standalone: false,
2122
selector: 'dark-mode-supporter',
2223
template: ``,
2324
styles: [

tensorboard/webapp/core/views/hash_storage_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ export enum ChangedProp {
3232
}
3333

3434
@Component({
35+
standalone: false,
3536
selector: 'hash-storage-component',
3637
template: '',
3738
changeDetection: ChangeDetectionStrategy.OnPush,

tensorboard/webapp/core/views/hash_storage_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {getActivePlugin} from '../store';
2020
import {ChangedProp} from './hash_storage_component';
2121

2222
@Component({
23+
standalone: false,
2324
selector: 'hash-storage',
2425
template: `
2526
<hash-storage-component

tensorboard/webapp/core/views/layout_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import {
3030
} from '../store/core_selectors';
3131

3232
@Component({
33+
standalone: false,
3334
selector: 'tb-dashboard-layout',
3435
template: `
3536
<button

tensorboard/webapp/core/views/layout_test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,21 @@ import {
3030
import {LayoutContainer} from './layout_container';
3131

3232
@Component({
33+
standalone: false,
3334
selector: 'sidebar',
3435
template: `sidebar content`,
3536
})
3637
class Sidebar {}
3738

3839
@Component({
40+
standalone: false,
3941
selector: 'main',
4042
template: `main content`,
4143
})
4244
class Main {}
4345

4446
@Component({
47+
standalone: false,
4548
selector: 'testable-component',
4649
template: `
4750
<tb-dashboard-layout>

tensorboard/webapp/core/views/page_title_component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ const utils = {
2929
};
3030

3131
@Component({
32+
standalone: false,
3233
selector: 'page-title-component',
3334
template: '',
3435
changeDetection: ChangeDetectionStrategy.OnPush,

tensorboard/webapp/core/views/page_title_container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ const DEFAULT_BRAND_NAME = 'TensorBoard';
4343
* Renders page title.
4444
*/
4545
@Component({
46+
standalone: false,
4647
selector: 'page-title',
4748
template: `
4849
<page-title-component [title]="title$ | async"></page-title-component>

tensorboard/webapp/core/views/page_title_test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ describe('page title test', () => {
112112
});
113113

114114
@Component({
115+
standalone: false,
115116
selector: 'my-tester',
116117
template: ` <page-title></page-title> `,
117118
})

tensorboard/webapp/customization/customizable_component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ import {
5858
*
5959
* @Injectable()
6060
* @Component({
61+
* standalone: false,
6162
* selector: 'my-custom-button-component',
6263
* template: '<button mat-button>I am a special button!</button>'
6364
* })
@@ -74,6 +75,7 @@ import {
7475
* })
7576
*/
7677
@Component({
78+
standalone: false,
7779
selector: 'tb-customization',
7880
template: `
7981
<ng-container *ngIf="!customizableComponent">

0 commit comments

Comments
 (0)