Skip to content

Remove temporary GOPATH creation for codegen and openapigen. #8718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
twoGiants opened this issue Apr 18, 2025 · 1 comment · May be fixed by #8719
Open
2 tasks done

Remove temporary GOPATH creation for codegen and openapigen. #8718

twoGiants opened this issue Apr 18, 2025 · 1 comment · May be fixed by #8719
Assignees
@twoGiants
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@twoGiants
Copy link
Contributor

twoGiants commented Apr 18, 2025 •
edited
Loading

Summary

Running make generated takes locally 15-20min, under the hood the setup-temporary-gopath.sh is called which uses the legacy GOPATH configuration, creates a temporary directory and downloads all the dependencies every time once for codegen and once for openaipgen.

You appear to be running from outside of GOPATH.
This script will create a temporary GOPATH at /tmp/tmp.6VNP0PcJTs/.gopath for code generation.
Moving to /tmp/tmp.6VNP0PcJTs/.gopath/src/github.com/tektoncd/pipeline

Running make generated without setup-temporary-gopath.sh takes under 2min.

Tasks

  • Remove setup-temporary-gopath.sh from update-codegen.sh and update-openapigen.sh.
  • Validate build, tests and CI remain running.
@twoGiants twoGiants linked a pull request Apr 18, 2025 that will close this issue
Open
8 tasks
@twoGiants
Copy link
Contributor Author

/kind cleanup

/assign

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoGiants twoGiants

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
2 participants
@twoGiants @tekton-robot