default-timeout-minutes Design Considerations

[danielhelfand]

Format of Default Timeout

Via the config-defaults ConfigMap, a property called default-timeout-minutes can be set to apply a timeout to every TaskRun/PipelineRun that does not specify a timeout. I think it would be helpful to be able to specify this default in a duration format (e.g., 1h30m2s). This would allow users to specify timeouts in a more granular way as opposed to only using minutes:

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: config-defaults
  namespace: tekton-pipelines
data:
  default-timeout: "1h30m2s"

This would also be more consistent with all the examples of timeouts used by pipeline/how tkn is allowing users to specify timeouts.

TaskRun Versus PipelineRun Timeout Defaults

The other suggestion would be to have a way to set timeout defaults for TaskRuns versus PipelineRuns as a default timeout for a TaskRun should more than likely differ from that of an entire PipelineRun.

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: config-defaults
  namespace: tekton-pipelines
data:
  default-taskrun-timeout: "10m"
  default-pipelinerun-timeout: "30m"

Additional Info

Assuming this makes sense, there would need to be some considerations on what the best approach would be to make this backwards compatible with default-timeout-minutes.

/kind feature

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danielhelfand]

/reopen

[tekton-robot]

@danielhelfand: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[vdemeester]

/remove-lifecycle rotten
/lifecycle frozen