Skip to content

Texture Is Sideways #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattdesl opened this issue Aug 7, 2014 · 4 comments
Open

Texture Is Sideways #3

mattdesl opened this issue Aug 7, 2014 · 4 comments

Comments

@mattdesl
Copy link
Member

mattdesl commented Aug 7, 2014

My code looks like this:

var image = require('baboon-image')
var tex = require('gl-texture2d')(gl, image)

And the image is stored on the GPU sideways. Seems like an unusual way of doing things. Any reasoning for this? Version 1.0.1 doesn't present this problem.

side

EDIT: Seems to happen on the example in the readme, too.

@mattdesl
Copy link
Member Author

Any ideas where this might be coming from? I can give a PR if I find a fix.

@hughsk
Copy link
Member

hughsk commented Sep 27, 2014

@mattdesl pretty sure the columns/rows vs width/height thing, it might be that baboon-image hasn't been updated for those changes?

A quick fix would be to do image.transpose(1, 0, 2) :)

@mikolalysenko
Copy link
Member

The issue is the baboon-image module, and more broadly older ndarray modules which used (rows,columns). You can just transpose it for now (like Hugh suggests). I'm slowly working through the backlog of stuff to bring things in order with the new (width,height) convention.

@mattdesl
Copy link
Member Author

looks like ndpack-image is the culprit, any easy fix so we can start patching this properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants