Merge pull request #105 from staadecker/shahzil.lakhani/bump-nodejs-version-jan2024

Update all three cloud functions to use NodeJS 20; update documentation and test student membership fee to be $25

Author: staadecker

README.md

@@ -1,6 +1,6 @@
 # UTOC Membership System
 
-While serving as Webmaster for the University of Toronto Outing Club (UTOC), I built this system to track and manage the club's members. As of fall 2023, the system is still in use and allows UTOC to contact members via a mailing list, accept membership payments online, and automatically remind people to renew their memberships upon expiry.
+While serving as Webmaster for the University of Toronto Outing Club (UTOC), I built this system to track and manage the club's members. As of Winter 2024, the system is still in use and allows UTOC to contact members via a mailing list, accept membership payments online, and automatically remind people to renew their memberships upon expiry.
 
 The entire system is open source, available in this repository, and runs completely free since it does not exceed UTOC's Google Cloud Platform's free quotas.
 

components/expired-members-remover/cloudbuild.yaml

@@ -7,7 +7,7 @@ steps:
       - --source=./components/expired-members-remover
       - --region=northamerica-northeast1
       - --entry-point=main
-      - --runtime=nodejs10
+      - --runtime=nodejs20
       - --trigger-topic=expired-members-remover
       - --timeout=300 # 5 minute timeout
 # The following lines should be used only when creating the function

components/membership-form-backend-trigger/cloudbuild.yaml

@@ -7,7 +7,7 @@ steps:
       - --source=./components/membership-form-backend-trigger
       - --region=northamerica-northeast1
       - --entry-point=main
-      - --runtime=nodejs10
+      - --runtime=nodejs20
       - --trigger-http
 # The following lines should be used only when creating the function
 #      - --allow-unauthenticated # requires Security Admin permissions

components/membership-form-backend/README.md

@@ -70,4 +70,6 @@ Run `npm run deploy`.
 
 - `Missing parameter '' in Google Sheet database header`: The Google sheets database doesn't have a column for that parameter and therefore that data was lost.
 
-- `Getting metadata from plugin failed with error: invalid_grant`: You likely have not run `npm run auth` recently.
+- `Getting metadata from plugin failed with error: invalid_grant`: You likely have not run `npm run auth` recently.
+  
+- `Email sending failing in unittests`: Temporarily remove the environment filter in the `sendSuccessEmail` function.

components/membership-form-backend/cloudbuild.yaml

@@ -7,7 +7,7 @@ steps:
       - --source=./components/membership-form-backend
       - --region=northamerica-northeast1
       - --entry-point=main
-      - --runtime=nodejs10
+      - --runtime=nodejs20
       - --trigger-topic=membership-form-backend
       - --timeout=300 # 5 minute timeout
 # The following lines should be used only when creating the function

components/membership-form-backend/index.test.js

@@ -38,7 +38,7 @@ const last = (array) => array[array.length - 1];
 jest.mock("@paypal/checkout-server-sdk", () => {
   const mocks = {
     getOrderAmount: jest.fn(() => {
-      return "20";
+      return "25";
     }),
     buildClient: jest.fn(),
     captureRequest: jest.fn(),