Skip to content

Commit a5ee7e2

Browse files
authored
Merge pull request #105 from staadecker/shahzil.lakhani/bump-nodejs-version-jan2024
Update all three cloud functions to use NodeJS 20; update documentation and test student membership fee to be $25
2 parents 23368e3 + 1bdb166 commit a5ee7e2

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# UTOC Membership System
22

3-
While serving as Webmaster for the University of Toronto Outing Club (UTOC), I built this system to track and manage the club's members. As of fall 2023, the system is still in use and allows UTOC to contact members via a mailing list, accept membership payments online, and automatically remind people to renew their memberships upon expiry.
3+
While serving as Webmaster for the University of Toronto Outing Club (UTOC), I built this system to track and manage the club's members. As of Winter 2024, the system is still in use and allows UTOC to contact members via a mailing list, accept membership payments online, and automatically remind people to renew their memberships upon expiry.
44

55
The entire system is open source, available in this repository, and runs completely free since it does not exceed UTOC's Google Cloud Platform's free quotas.
66

components/expired-members-remover/cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ steps:
77
- --source=./components/expired-members-remover
88
- --region=northamerica-northeast1
99
- --entry-point=main
10-
- --runtime=nodejs10
10+
- --runtime=nodejs20
1111
- --trigger-topic=expired-members-remover
1212
- --timeout=300 # 5 minute timeout
1313
# The following lines should be used only when creating the function

components/membership-form-backend-trigger/cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ steps:
77
- --source=./components/membership-form-backend-trigger
88
- --region=northamerica-northeast1
99
- --entry-point=main
10-
- --runtime=nodejs10
10+
- --runtime=nodejs20
1111
- --trigger-http
1212
# The following lines should be used only when creating the function
1313
# - --allow-unauthenticated # requires Security Admin permissions

components/membership-form-backend/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,6 @@ Run `npm run deploy`.
7070

7171
- `Missing parameter '' in Google Sheet database header`: The Google sheets database doesn't have a column for that parameter and therefore that data was lost.
7272

73-
- `Getting metadata from plugin failed with error: invalid_grant`: You likely have not run `npm run auth` recently.
73+
- `Getting metadata from plugin failed with error: invalid_grant`: You likely have not run `npm run auth` recently.
74+
75+
- `Email sending failing in unittests`: Temporarily remove the environment filter in the `sendSuccessEmail` function.

components/membership-form-backend/cloudbuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ steps:
77
- --source=./components/membership-form-backend
88
- --region=northamerica-northeast1
99
- --entry-point=main
10-
- --runtime=nodejs10
10+
- --runtime=nodejs20
1111
- --trigger-topic=membership-form-backend
1212
- --timeout=300 # 5 minute timeout
1313
# The following lines should be used only when creating the function

components/membership-form-backend/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const last = (array) => array[array.length - 1];
3838
jest.mock("@paypal/checkout-server-sdk", () => {
3939
const mocks = {
4040
getOrderAmount: jest.fn(() => {
41-
return "20";
41+
return "25";
4242
}),
4343
buildClient: jest.fn(),
4444
captureRequest: jest.fn(),

0 commit comments

Comments
 (0)