Skip to content

Refactor the tenant child model functionality for sub-tenancies #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
ollieread opened this issue Feb 19, 2025 · 0 comments
Open
3 tasks

Refactor the tenant child model functionality for sub-tenancies #107

ollieread opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
status: accepted The issue has been accepted/acknowledged and is being actioned or will be status: investigating The issue is being investigated type: refactor Refactoring of code

Comments

@ollieread
Copy link
Member

ollieread commented Feb 19, 2025

The Eloquent child model functionality will need looking at, as it currently relies on the tenancy name coming from a method, and restricts usage of TenantRelation to a single method. I believe the following is the best way to improve this to better support sub-tenancies:

  • Remove the reliance on the IsTenantChild::getTenancyName() method.
  • Remove the restriction on the number of TenantRelation occurrences.
  • Add a tenancy name option to TenantRelation, for models that can belong to multiple kinds of tenancies.
@ollieread ollieread self-assigned this Feb 19, 2025
@ollieread ollieread added type: refactor Refactoring of code status: investigating The issue is being investigated status: accepted The issue has been accepted/acknowledged and is being actioned or will be labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted The issue has been accepted/acknowledged and is being actioned or will be status: investigating The issue is being investigated type: refactor Refactoring of code
Projects
Status: Backlog
Development

No branches or pull requests

1 participant