Skip to content

Wait for callback instead of retrying while waiting for child object #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
QuadratClown opened this issue Aug 19, 2020 · 0 comments
Open

Wait for callback instead of retrying while waiting for child object #2

QuadratClown opened this issue Aug 19, 2020 · 0 comments
Labels
enhancement New feature or request severity: low

Comments

@QuadratClown
Copy link
Member

QuadratClown commented Aug 19, 2020 •
edited
Loading

see getChildObject in base_interface.ts

if (options.maxRetries > 0) {
            await sleep(options.retryIntervalMs)
            options.maxRetries--
            return this.getChildObject(interfaceName, constructor, filter, options)
}

better way to do it by checking incoming InterfacesAdded events instead
@QuadratClown QuadratClown added the enhancement New feature or request label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request severity: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuadratClown