Skip to content
This repository was archived by the owner on Feb 10, 2024. It is now read-only.

Commit baea08e

Browse files
authored
Merge pull request #268 from skttl/develop
1.2.8
2 parents 070fc9b + 3fd1b6d commit baea08e

File tree

5 files changed

+12
-3
lines changed

5 files changed

+12
-3
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## 1.2.8
9+
- Fixes bug in DataValueReference for media tracking, where custom DTGEs were not recognized. 4db5cdd
10+
11+
## 1.2.7
12+
- Fixes: Unable to save a component which previously failed validation #231
13+
- Null-check for err object when submiting #236
14+
815
## 1.2.6 - 2020-12-07
916
- Fix: Error saving temp blueprint
1017
- Fix: issue when previewing linked content items

appveyor.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
image: Visual Studio 2017
22

33
# version format
4-
version: 1.2.7.{build}
4+
version: 1.2.8.{build}
55

66
# UMBRACO_PACKAGE_PRERELEASE_SUFFIX if a rtm release build this should be blank, otherwise if empty will default to alpha
77
# example UMBRACO_PACKAGE_PRERELEASE_SUFFIX=beta

docs/developers-guide.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
5. [Rendering a Doc Type Grid Editor](#rendering-a-doc-type-grid-editor)
1111
1. [Rendering Alternative Preview Content](#rendering-alternative-preview-content)
1212
2. [DocTypeGridEditorSurfaceController](#doctypegrideditorsurfacecontroller)
13-
6. [Useful Links](#useful-links)
13+
6. [Value Processors](#value-processors)
14+
7. [Useful Links](#useful-links)
1415

1516
---
1617

src/Our.Umbraco.DocTypeGridEditor/ValueProcessing/DocTypeGridEditorDataValueReference.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ internal GridValue DeserializeGridValue(string rawJson, out IEnumerable<DocTypeG
7171
{
7272
// Find all controls that uses DTGE editor
7373
var controls = grid.Sections.SelectMany(x => x.Rows.SelectMany(r => r.Areas).SelectMany(a => a.Controls)).ToArray();
74-
dtgeValues = controls.Where(x => x.Editor.Alias.ToLowerInvariant() == "doctype").Select(x => x.Value.ToObject<DocTypeGridEditorValue>());
74+
dtgeValues = controls.Where(x => x.Value["dtgeContentTypeAlias"] != null).Select(x => x.Value.ToObject<DocTypeGridEditorValue>());
7575
}
7676
else
7777
{

src/Our.Umbraco.DocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.controllers.js

+1
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ angular.module("umbraco").controller("Our.Umbraco.DocTypeGridEditor.Dialogs.DocT
267267

268268
function submit() {
269269
if ($scope.model.submit) {
270+
serverValidationManager.reset();
270271
vm.saveButtonState = "busy";
271272
$scope.model.node.name = "Dtge Temp: " + $scope.model.node.key;
272273
$scope.model.node.variants[0].name = $scope.model.node.name

0 commit comments

Comments
 (0)