Skip to content

Commit 459b968

Browse files
committed
revert tfhistogram changes
sad commit
1 parent 5f8403d commit 459b968

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/shogun/lib/tfhistogram/histogram.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ limitations under the License.
1818
#ifdef HAVE_TFLOGGER
1919

2020
#include "histogram.h"
21-
#include <limits>
21+
#include <float.h>
22+
#include <math.h>
2223
#include <vector>
2324
#include <algorithm>
2425
#include <tflogger/summary.pb.h>
@@ -36,8 +37,8 @@ static std::vector<double>* InitDefaultBucketsInner() {
3637
neg_buckets.push_back(-v);
3738
v *= 1.1;
3839
}
39-
buckets.push_back(std::numeric_limits<double>::max());
40-
neg_buckets.push_back(-std::numeric_limits<double>::max());
40+
buckets.push_back(DBL_MAX);
41+
neg_buckets.push_back(-DBL_MAX);
4142
std::reverse(neg_buckets.begin(), neg_buckets.end());
4243
std::vector<double>* result = new std::vector<double>;
4344
result->insert(result->end(), neg_buckets.begin(), neg_buckets.end());
@@ -84,7 +85,7 @@ bool Histogram::DecodeFromProto(const HistogramProto& proto) {
8485

8586
void Histogram::Clear() {
8687
min_ = bucket_limits_[bucket_limits_.size() - 1];
87-
max_ = -std::numeric_limits<double>::max();
88+
max_ = -DBL_MAX;
8889
num_ = 0;
8990
sum_ = 0;
9091
sum_squares_ = 0;
@@ -177,7 +178,7 @@ std::string Histogram::ToString() const {
177178
if (buckets_[b] <= 0.0) continue;
178179
sum += buckets_[b];
179180
snprintf(buf, sizeof(buf), "[ %10.2g, %10.2g ) %7.0f %7.3f%% %7.3f%% ",
180-
((b == 0) ? -std::numeric_limits<double>::max() : bucket_limits_[b - 1]), // left
181+
((b == 0) ? -DBL_MAX : bucket_limits_[b - 1]), // left
181182
bucket_limits_[b], // right
182183
buckets_[b], // count
183184
mult * buckets_[b], // percentage
@@ -217,7 +218,7 @@ void Histogram::EncodeToProto(HistogramProto* proto,
217218
}
218219
if (proto->bucket_size() == 0.0) {
219220
// It's easier when we restore if we always have at least one bucket entry
220-
proto->add_bucket_limit(std::numeric_limits<double>::max());
221+
proto->add_bucket_limit(DBL_MAX);
221222
proto->add_bucket(0.0);
222223
}
223224
}

0 commit comments

Comments
 (0)