Skip to content

Commit 28a085d

Browse files
stipsansnorrees
authored andcommitted
fix: npmignore not needed as we use pkg.files
1 parent a0718b5 commit 28a085d

File tree

10 files changed

+1
-69
lines changed

10 files changed

+1
-69
lines changed

.npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ If the plugin is shared across multiple "private" studios: register an organizat
239239
Also; you cannot easily remove modules/versions from npm once published.
240240
Take a good look at your `package.json` to see that the fields in there makes sense to you,
241241
and make sure there are no "secrets" (authorization tokens, API keys or similar) in the plugin directory -
242-
anything not listed in `.npmignore` will be part of the published module.
242+
any files within folders defined in the `files` field inside `package.json` will be included with your module.
243243

244244
When you're ready to publish, run `npm publish` (or `yarn publish` if you prefer).
245245
The `prepublishOnly` task should kick in and compile the source files, then verify the built output to ensure it looks good.

assets/inject/npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

src/actions/inject.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,6 @@ async function writeStaticAssets(options: InjectOptions) {
346346

347347
const files: FromTo[] = [
348348
{from: 'editorconfig', to: '.editorconfig'},
349-
{from: 'npmignore', to: '.npmignore'},
350349
{from: 'sanity.json', to: 'sanity.json'},
351350
{from: 'v2-incompatible.js.template', to: 'v2-incompatible.js'},
352351
{

test/fixtures/inject/valid/.npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

test/fixtures/verify-package/every-failure-possible/.npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

test/fixtures/verify-package/fresh-v2-movie-studio/.npmignore

Lines changed: 0 additions & 12 deletions
This file was deleted.

test/fixtures/verify-package/invalid-eslint/.npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

test/fixtures/verify-package/valid/.npmignore

Lines changed: 0 additions & 9 deletions
This file was deleted.

test/init.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ tap.test('plugin-kit init --force in empty directory', async (t) => {
6161
'lint-staged.config.js',
6262
'*.js'
6363
)
64-
await fileContains('.npmignore', '/test')
6564
await fileContains('.prettierrc.js', 'semi: false')
6665
await fileContains('sanity.json', '"path": "./v2-incompatible.js"')
6766
await fileContains('v2-incompatible.js', 'showIncompatiblePluginDialog')

0 commit comments

Comments
 (0)