fix code format and CI error

Author: cocodery

clippy_lints/src/methods/unnecessary_iter_cloned.rs

@@ -56,51 +56,39 @@ pub fn check_for_loop_iter(
             }
         }
 
-        if let Some(caller) = if let ExprKind::Call(_, [child, ..]) = expr.kind {
-            // filter first layer of iterator
-            let mut child = child;
-            // get inner real caller requests for clone
-            while let ExprKind::MethodCall(_, caller, _, _) = child.kind {
-                child = caller;
-            }
-            Some(child)
-        } else {
-            None
-        } && is_mutable(cx, caller)
-        {
-            // all clones get from explicit function call
-            // the suggestions out of this scope will handle for immutable caller
-            // only check for mutable caller here
-            // if caller is mutable and caller or its fields are changed
-            // the lint should not execute
-            if if let ExprKind::Block(block, ..) = body.kind {
-                let mut no_change = true;
-                // check whether caller is mutable and caller or its fields are changed in this loop
+        fn is_caller_or_fields_changed(cx: &LateContext<'_>, body: &Expr<'_>, caller: &Expr<'_>) -> bool {
+            if let ExprKind::Block(block, ..) = body.kind {
                 for stmt in block.stmts {
                     if let StmtKind::Semi(e) = stmt.kind {
-                        // dont check `is_mutable` for `lhs` here because assign to an immutable variable is an error
-                        if let Some(lhs) = match e.kind {
-                            ExprKind::Assign(lhs, _, _) => Some(lhs),
-                            ExprKind::AssignOp(_, lhs, _) => Some(lhs),
+                        // dont check `is_mutable` for `lhs` here because
+                        // assign to an immutable variable is an error
+                        if let Some(assignee) = match e.kind {
+                            ExprKind::Assign(assignee, _, _) | ExprKind::AssignOp(_, assignee, _) => Some(assignee),
                             _ => None,
                         } {
-                            no_change = can_mut_borrow_both(cx, caller, lhs);
-                        }
-                        if !no_change {
-                            // if one change occurs, stop the loop
-                            break;
+                            if !can_mut_borrow_both(cx, caller, assignee) {
+                                return true;
+                            }
                         }
                     }
                 }
-                !no_change
-            } else {
-                false
-            } {
-                // skip this lint
-                return true;
             }
+            false
         }
 
+        if let ExprKind::Call(_, [child, ..]) = expr.kind {
+            // filter first layer of iterator
+            let mut child = child;
+            // get inner real caller requests for clone
+            while let ExprKind::MethodCall(_, caller, _, _) = child.kind {
+                child = caller;
+            }
+            if is_mutable(cx, child) && is_caller_or_fields_changed(cx, body, child) {
+                // skip lint
+                return true;
+            }
+        };
+
         // the lint should not be executed if no violation happens
         let snippet = if let ExprKind::MethodCall(maybe_iter_method_name, collection, [], _) = receiver.kind
             && maybe_iter_method_name.ident.name == sym::iter