m1

Author: Jarcho

clippy_lints/src/ineffective_open_options.rs

@@ -1,4 +1,4 @@
-use crate::methods::method_call;
+use super::method_call;
 use clippy_utils::diagnostics::span_lint_and_sugg;
 use clippy_utils::peel_blocks;
 use declare_clippy_lint::declare_clippy_lint;

clippy_lints/src/methods/chars_next_cmp.rs

@@ -0,0 +1,28 @@
+[package]
+name = "clippy_lints_methods"
+version = "0.1.89"
+description = "A bunch of helpful lints to avoid common pitfalls in Rust"
+repository = "https://github.com/rust-lang/rust-clippy"
+readme = "../README.md"
+license = "MIT OR Apache-2.0"
+keywords = ["clippy", "lint", "plugin"]
+edition = "2024"
+
+[dependencies]
+# arrayvec = { version = "0.7", default-features = false }
+# cargo_metadata = "0.18"
+clippy_config = { path = "../clippy_config" }
+clippy_utils = { path = "../clippy_utils" }
+# itertools = "0.12"
+# quine-mc_cluskey = "0.2"
+# regex-syntax = "0.8"
+# serde = { version = "1.0", features = ["derive"] }
+# toml = "0.7.3"
+# unicode-normalization = "0.1"
+# unicode-script = { version = "0.5", default-features = false }
+# semver = "1.0"
+# url = "2.2"
+
+[package.metadata.rust-analyzer]
+# This crate uses #[feature(rustc_private)]
+rustc_private = true

clippy_lints/src/methods/chars_next_cmp_with_unwrap.rs

@@ -5,7 +5,7 @@ use rustc_errors::Applicability;
 use rustc_hir::{Expr, LangItem};
 use rustc_lint::LateContext;
 
-use crate::methods::method_call;
+use super::method_call;
 
 use super::BYTES_NTH;
 

clippy_lints_methods/Cargo.toml

@@ -9,7 +9,7 @@ use rustc_middle::ty;
 /// Wrapper fn for `CHARS_NEXT_CMP` and `CHARS_LAST_CMP` lints.
 pub(super) fn check(
     cx: &LateContext<'_>,
-    info: &crate::methods::BinaryExprInfo<'_>,
+    info: &super::BinaryExprInfo<'_>,
     chain_methods: &[&str],
     lint: &'static Lint,
     suggest: &str,

clippy_lints/src/methods/bind_instead_of_map.rs renamed to clippy_lints_methods/src/bind_instead_of_map.rs

@@ -9,7 +9,7 @@ use rustc_lint::{LateContext, Lint};
 /// Wrapper fn for `CHARS_NEXT_CMP` and `CHARS_LAST_CMP` lints with `unwrap()`.
 pub(super) fn check(
     cx: &LateContext<'_>,
-    info: &crate::methods::BinaryExprInfo<'_>,
+    info: &super::BinaryExprInfo<'_>,
     chain_methods: &[&str],
     lint: &'static Lint,
     suggest: &str,

clippy_lints/src/methods/bytecount.rs renamed to clippy_lints_methods/src/bytecount.rs

@@ -1,10 +1,10 @@
-use crate::methods::chars_cmp;
+use super::chars_cmp;
 use rustc_lint::LateContext;
 
 use super::CHARS_LAST_CMP;
 
 /// Checks for the `CHARS_LAST_CMP` lint.
-pub(super) fn check(cx: &LateContext<'_>, info: &crate::methods::BinaryExprInfo<'_>) -> bool {
+pub(super) fn check(cx: &LateContext<'_>, info: &super::BinaryExprInfo<'_>) -> bool {
     if chars_cmp::check(cx, info, &["chars", "last"], CHARS_LAST_CMP, "ends_with") {
         true
     } else {

clippy_lints/src/methods/bytes_count_to_len.rs renamed to clippy_lints_methods/src/bytes_count_to_len.rs

@@ -1,10 +1,10 @@
-use crate::methods::chars_cmp_with_unwrap;
+use super::chars_cmp_with_unwrap;
 use rustc_lint::LateContext;
 
 use super::CHARS_LAST_CMP;
 
 /// Checks for the `CHARS_LAST_CMP` lint with `unwrap()`.
-pub(super) fn check(cx: &LateContext<'_>, info: &crate::methods::BinaryExprInfo<'_>) -> bool {
+pub(super) fn check(cx: &LateContext<'_>, info: &super::BinaryExprInfo<'_>) -> bool {
     if chars_cmp_with_unwrap::check(cx, info, &["chars", "last", "unwrap"], CHARS_LAST_CMP, "ends_with") {
         true
     } else {

clippy_lints/src/methods/bytes_nth.rs renamed to clippy_lints_methods/src/bytes_nth.rs

@@ -0,0 +1,8 @@
+use rustc_lint::LateContext;
+
+use super::CHARS_NEXT_CMP;
+
+/// Checks for the `CHARS_NEXT_CMP` lint.
+pub(super) fn check(cx: &LateContext<'_>, info: &super::BinaryExprInfo<'_>) -> bool {
+    super::chars_cmp::check(cx, info, &["chars", "next"], CHARS_NEXT_CMP, "starts_with")
+}

clippy_lints/src/methods/case_sensitive_file_extension_comparisons.rs renamed to clippy_lints_methods/src/case_sensitive_file_extension_comparisons.rs

@@ -0,0 +1,8 @@
+use rustc_lint::LateContext;
+
+use super::CHARS_NEXT_CMP;
+
+/// Checks for the `CHARS_NEXT_CMP` lint with `unwrap()`.
+pub(super) fn check(cx: &LateContext<'_>, info: &super::BinaryExprInfo<'_>) -> bool {
+    super::chars_cmp_with_unwrap::check(cx, info, &["chars", "next", "unwrap"], CHARS_NEXT_CMP, "starts_with")
+}

clippy_lints/src/methods/chars_cmp.rs renamed to clippy_lints_methods/src/chars_cmp.rs

@@ -1,4 +1,4 @@
-use crate::methods::DRAIN_COLLECT;
+use super::DRAIN_COLLECT;
 use clippy_utils::diagnostics::span_lint_and_sugg;
 use clippy_utils::source::snippet;
 use clippy_utils::ty::is_type_lang_item;

clippy_lints/src/methods/chars_cmp_with_unwrap.rs renamed to clippy_lints_methods/src/chars_cmp_with_unwrap.rs

@@ -1,4 +1,4 @@
-use crate::methods::utils::derefs_to_slice;
+use super::utils::derefs_to_slice;
 use clippy_utils::diagnostics::span_lint_and_sugg;
 use clippy_utils::ty::{get_iterator_item_ty, is_type_diagnostic_item};
 use rustc_errors::Applicability;

clippy_lints/src/methods/chars_last_cmp.rs renamed to clippy_lints_methods/src/chars_last_cmp.rs

@@ -1,3 +1,61 @@
+// #![feature(array_windows)]
+// #![feature(box_patterns)]
+// #![feature(macro_metavar_expr_concat)]
+// #![feature(f128)]
+// #![feature(f16)]
+// #![feature(if_let_guard)]
+// #![feature(iter_intersperse)]
+// #![feature(iter_partition_in_place)]
+// #![feature(never_type)]
+// #![feature(round_char_boundary)]
+#![feature(rustc_private)]
+// #![feature(stmt_expr_attributes)]
+// #![feature(unwrap_infallible)]
+#![allow(
+    clippy::missing_docs_in_private_items,
+    clippy::must_use_candidate,
+    rustc::diagnostic_outside_of_impl,
+    rustc::untranslatable_diagnostic,
+    clippy::literal_string_with_formatting_args
+)]
+#![warn(
+    trivial_casts,
+    trivial_numeric_casts,
+    rust_2018_idioms,
+    unused_lifetimes,
+    unused_qualifications,
+    rustc::internal
+)]
+
+// FIXME: switch to something more ergonomic here, once available.
+// (Currently there is no way to opt into sysroot crates without `extern crate`.)
+// extern crate pulldown_cmark;
+// extern crate rustc_abi;
+// extern crate rustc_arena;
+// extern crate rustc_ast;
+// extern crate rustc_ast_pretty;
+// extern crate rustc_attr_parsing;
+// extern crate rustc_data_structures;
+extern crate rustc_driver;
+extern crate rustc_errors;
+extern crate rustc_hir;
+// extern crate rustc_hir_analysis;
+// extern crate rustc_hir_pretty;
+// extern crate rustc_hir_typeck;
+// extern crate rustc_index;
+// extern crate rustc_infer;
+// extern crate rustc_lexer;
+extern crate rustc_lint;
+extern crate rustc_middle;
+// extern crate rustc_parse;
+// extern crate rustc_parse_format;
+// extern crate rustc_resolve;
+// extern crate rustc_session;
+extern crate rustc_span;
+// extern crate rustc_target;
+// extern crate rustc_trait_selection;
+// extern crate thin_vec;
+
 mod bind_instead_of_map;
 mod bytecount;
 mod bytes_count_to_len;

clippy_lints/src/methods/chars_last_cmp_with_unwrap.rs renamed to clippy_lints_methods/src/chars_last_cmp_with_unwrap.rs

@@ -1,4 +1,4 @@
-use crate::methods::MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES;
+use super::MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES;
 use clippy_utils::diagnostics::span_lint_and_then;
 use clippy_utils::msrvs::{self, Msrv};
 use clippy_utils::source::snippet_with_applicability;

clippy_lints_methods/src/chars_next_cmp.rs

@@ -1,4 +1,4 @@
-use crate::methods::{single_char_insert_string, single_char_push_string};
+use super::{single_char_insert_string, single_char_push_string};
 use rustc_hir as hir;
 use rustc_lint::LateContext;
 use rustc_span::sym;

clippy_lints_methods/src/chars_next_cmp_with_unwrap.rs

@@ -1,4 +1,4 @@
-use crate::methods::TYPE_ID_ON_BOX;
+use super::TYPE_ID_ON_BOX;
 use clippy_utils::diagnostics::span_lint_and_then;
 use clippy_utils::source::snippet;
 use rustc_errors::Applicability;

clippy_lints/src/methods/clear_with_drain.rs renamed to clippy_lints_methods/src/clear_with_drain.rs

@@ -1,4 +1,4 @@
-use crate::methods::SelfKind;
+use super::SelfKind;
 use clippy_utils::diagnostics::span_lint_and_help;
 use clippy_utils::ty::is_copy;
 use rustc_lint::LateContext;