Skip to content

Commit f3bad5f

Browse files
authored
fix(collector): fix helm collector with a nil error return to error list (#1535)
1 parent f438467 commit f3bad5f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/collect/helm.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ func helmReleaseHistoryCollector(releaseName string, namespace string, collectVa
105105
return nil, []error{err}
106106
}
107107
versionInfo, err := getVersionInfo(actionConfig, r.Name, r.Namespace, collectValues)
108+
if err != nil {
109+
return nil, []error{err}
110+
}
108111
results = append(results, ReleaseInfo{
109112
ReleaseName: r.Name,
110113
Chart: r.Chart.Metadata.Name,
@@ -113,7 +116,7 @@ func helmReleaseHistoryCollector(releaseName string, namespace string, collectVa
113116
Namespace: r.Namespace,
114117
VersionInfo: versionInfo,
115118
})
116-
return results, []error{err}
119+
return results, nil
117120
}
118121

119122
// If releaseName is not specified, get the history of all releases

0 commit comments

Comments
 (0)