Skip to content

Commit b19ac90

Browse files
authored
Merge pull request #76 from replicatedhq/divolgin/containerz
Change containers to containerNames to not break kustomize
2 parents 218b9c0 + 13fb6ab commit b19ac90

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

pkg/apis/troubleshoot/v1beta1/collector_shared.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ type LogLimits struct {
2424
}
2525

2626
type Logs struct {
27-
CollectorMeta `json:",inline" yaml:",inline"`
28-
Name string `json:"name,omitempty" yaml:"name,omitempty"`
29-
Selector []string `json:"selector" yaml:"selector"`
30-
Namespace string `json:"namespace,omitempty" yaml:"namespace,omitempty"`
31-
Containers []string `json:"containers,omitempty" yaml:"containers,omitempty"`
32-
Limits *LogLimits `json:"limits,omitempty" yaml:"omitempty"`
27+
CollectorMeta `json:",inline" yaml:",inline"`
28+
Name string `json:"name,omitempty" yaml:"name,omitempty"`
29+
Selector []string `json:"selector" yaml:"selector"`
30+
Namespace string `json:"namespace,omitempty" yaml:"namespace,omitempty"`
31+
ContainerNames []string `json:"containerNames,omitempty" yaml:"containerNames,omitempty"`
32+
Limits *LogLimits `json:"limits,omitempty" yaml:"omitempty"`
3333
}
3434

3535
type Run struct {

pkg/apis/troubleshoot/v1beta1/zz_generated.deepcopy.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/collect/logs.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func Logs(ctx *Context, logsCollector *troubleshootv1beta1.Logs) ([]byte, error)
3636

3737
if len(pods) > 0 {
3838
for _, pod := range pods {
39-
if len(logsCollector.Containers) == 0 {
39+
if len(logsCollector.ContainerNames) == 0 {
4040
podLogs, err := getPodLogs(client, pod, logsCollector.Name, "", logsCollector.Limits, false)
4141
if err != nil {
4242
key := fmt.Sprintf("%s/%s-errors.json", logsCollector.Name, pod.Name)
@@ -50,7 +50,7 @@ func Logs(ctx *Context, logsCollector *troubleshootv1beta1.Logs) ([]byte, error)
5050
logsOutput[k] = v
5151
}
5252
} else {
53-
for _, container := range logsCollector.Containers {
53+
for _, container := range logsCollector.ContainerNames {
5454
containerLogs, err := getPodLogs(client, pod, logsCollector.Name, container, logsCollector.Limits, false)
5555
if err != nil {
5656
key := fmt.Sprintf("%s/%s/%s-errors.json", logsCollector.Name, pod.Name, container)

0 commit comments

Comments
 (0)