chore: fix stack trace (#5312)

Author: emosbaugh

pkg/tasks/tasks.go

@@ -51,18 +51,16 @@ func StartTaskMonitor(taskID string, finishedChan <-chan error) {
 }
 
 func StartTicker(taskID string, finishedChan <-chan struct{}) {
-	go func() {
-		for {
-			select {
-			case <-time.After(time.Second * 2):
-				if err := UpdateTaskStatusTimestamp(taskID); err != nil {
-					logger.Error(err)
-				}
-			case <-finishedChan:
-				return
+	for {
+		select {
+		case <-time.After(time.Second * 2):
+			if err := UpdateTaskStatusTimestamp(taskID); err != nil {
+				logger.Error(err)
 			}
+		case <-finishedChan:
+			return
 		}
-	}()
+	}
 }
 
 func SetTaskStatus(id string, message string, status string) error {

pkg/upgradeservice/deploy/deploy.go

@@ -129,7 +129,7 @@ func Deploy(opts DeployOptions) error {
 
 		finishedCh := make(chan struct{})
 		defer close(finishedCh)
-		tasks.StartTicker(task.GetID(opts.Params.AppSlug), finishedCh)
+		go tasks.StartTicker(task.GetID(opts.Params.AppSlug), finishedCh)
 
 		if err := embeddedcluster.StartClusterUpgrade(context.Background(), opts.KotsKinds, opts.RegistrySettings); err != nil {
 			return errors.Wrap(err, "failed to start cluster upgrade")