skip cluster update modal for noop test

Author: sgalsaleh

e2e/playwright/tests/deploy-upgrade/test.spec.ts

@@ -5,7 +5,10 @@ test('deploy upgrade', async ({ page }) => {
   test.setTimeout(15 * 60 * 1000); // 15 minutes
   await login(page);
   await page.getByRole('link', { name: 'Version history', exact: true }).click();
-  await page.locator('.available-update-row', { hasText: process.env.APP_UPGRADE_VERSION }).getByRole('button', { name: 'Deploy', exact: true }).click();
+  // TODO NOW: uncomment this
+  // await page.locator('.available-update-row', { hasText: process.env.APP_UPGRADE_VERSION }).getByRole('button', { name: 'Deploy', exact: true }).click();
+  // TODO NOW: remove this line
+  await page.getByText(process.env.APP_UPGRADE_VERSION, { exact: true }).locator('../../..').getByRole('button', { name: 'Deploy', exact: true }).click();
   const iframe = page.frameLocator('#upgrade-service-iframe');
   await expect(iframe.locator('h3')).toContainText('The First Config Group', { timeout: 20 * 1000 });
   await expect(iframe.locator('input[type="text"]')).toHaveValue('initial-hostname.com');
@@ -23,11 +26,13 @@ test('deploy upgrade', async ({ page }) => {
   await expect(iframe.locator('#app')).toContainText('All preflight checks passed');
   await expect(iframe.getByRole('button', { name: 'Back: Preflight checks' })).toBeVisible();
   await iframe.getByRole('button', { name: 'Deploy', exact: true }).click();
-  await expect(page.locator('.Modal-body')).toContainText('Cluster update in progress');
-  await expect(page.locator('.Modal-body').getByText('Cluster update in progress')).not.toBeVisible({ timeout: 10 * 60 * 1000 });
-  // wait for the page to refresh after cluster update
-  await page.waitForTimeout(5000);
-  await expect(page.locator('.available-update-row', { hasText: process.env.APP_UPGRADE_VERSION })).not.toBeVisible();
+
+  if (process.env.SKIP_CLUSTER_UPGRADE_CHECK !== 'true') {
+    await expect(page.locator('.Modal-body')).toContainText('Cluster update in progress');
+    await expect(page.locator('.Modal-body').getByText('Cluster update in progress')).not.toBeVisible({ timeout: 10 * 60 * 1000 });
+  }
+
+  await expect(page.locator('.available-update-row', { hasText: process.env.APP_UPGRADE_VERSION })).not.toBeVisible({ timeout: 10 * 1000 });
   await expect(page.locator('.VersionHistoryRow', { hasText: process.env.APP_UPGRADE_VERSION })).toContainText('Currently deployed version', { timeout: 30 * 1000 });
   await page.getByRole('link', { name: 'Dashboard', exact: true }).click();
   await expect(page.locator('.VersionCard-content--wrapper')).toContainText(process.env.APP_UPGRADE_VERSION);

e2e/scripts/playwright.sh

@@ -17,9 +17,9 @@ main() {
     export DR_AWS_SECRET_ACCESS_KEY="$7"
   elif [ "$test_name" == "deploy-upgrade" ]; then
     export APP_UPGRADE_VERSION="$2"
+    export SKIP_CLUSTER_UPGRADE_CHECK="$3"
   fi
 
-
   export BASE_URL="http://10.0.0.2:30001"
   cd /automation/playwright
   npx playwright test "$test_name"