Skip to content

Commit 0970637

Browse files
authored
chore: rename flag to --manager-experience (#2202)
1 parent cb6403c commit 0970637

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

cmd/installer/cli/install.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ type InstallCmdFlags struct {
8282
networkInterface string
8383

8484
// guided UI flags
85-
managerPort int
86-
guidedUI bool
87-
tlsCertFile string
88-
tlsKeyFile string
89-
hostname string
85+
enableManagerExperience bool
86+
managerPort int
87+
tlsCertFile string
88+
tlsKeyFile string
89+
hostname string
9090

9191
// TODO: move to substruct
9292
license *kotsv1beta1.License
@@ -142,7 +142,7 @@ func InstallCmd(ctx context.Context, name string) *cobra.Command {
142142
metricsReporter.ReportInstallationSucceeded(ctx)
143143

144144
// If in guided UI mode, keep the process running until interrupted
145-
if flags.guidedUI {
145+
if flags.enableManagerExperience {
146146
logrus.Info("")
147147
logrus.Info("Installation complete. Press Ctrl+C to exit.")
148148
logrus.Info("")
@@ -159,7 +159,7 @@ func InstallCmd(ctx context.Context, name string) *cobra.Command {
159159
if err := addInstallAdminConsoleFlags(cmd, &flags); err != nil {
160160
panic(err)
161161
}
162-
if err := addGuidedUIFlags(cmd, &flags); err != nil {
162+
if err := addManagerExperienceFlags(cmd, &flags); err != nil {
163163
panic(err)
164164
}
165165

@@ -214,14 +214,14 @@ func addInstallAdminConsoleFlags(cmd *cobra.Command, flags *InstallCmdFlags) err
214214
return nil
215215
}
216216

217-
func addGuidedUIFlags(cmd *cobra.Command, flags *InstallCmdFlags) error {
218-
cmd.Flags().BoolVarP(&flags.guidedUI, "guided-ui", "g", false, "Run the installation in guided UI mode.")
217+
func addManagerExperienceFlags(cmd *cobra.Command, flags *InstallCmdFlags) error {
218+
cmd.Flags().BoolVar(&flags.enableManagerExperience, "manager-experience", false, "Run the browser-based installation experience.")
219219
cmd.Flags().IntVar(&flags.managerPort, "manager-port", ecv1beta1.DefaultManagerPort, "Port on which the Manager will be served")
220220
cmd.Flags().StringVar(&flags.tlsCertFile, "tls-cert", "", "Path to the TLS certificate file")
221221
cmd.Flags().StringVar(&flags.tlsKeyFile, "tls-key", "", "Path to the TLS key file")
222222
cmd.Flags().StringVar(&flags.hostname, "hostname", "", "Hostname to use for TLS configuration")
223223

224-
if err := cmd.Flags().MarkHidden("guided-ui"); err != nil {
224+
if err := cmd.Flags().MarkHidden("manager-experience"); err != nil {
225225
return err
226226
}
227227
if err := cmd.Flags().MarkHidden("manager-port"); err != nil {
@@ -279,7 +279,7 @@ func preRunInstall(cmd *cobra.Command, flags *InstallCmdFlags) error {
279279
}
280280
}
281281

282-
if flags.guidedUI {
282+
if flags.enableManagerExperience {
283283
configChan := make(chan *apitypes.InstallationConfig)
284284
defer close(configChan)
285285

@@ -636,7 +636,7 @@ func runInstall(ctx context.Context, name string, flags InstallCmdFlags, metrics
636636
logrus.Warnf("Unable to create host support bundle: %v", err)
637637
}
638638

639-
if flags.guidedUI {
639+
if flags.enableManagerExperience {
640640
if err := markUIInstallComplete(flags.adminConsolePassword, flags.managerPort); err != nil {
641641
return fmt.Errorf("unable to mark ui install complete: %w", err)
642642
}

0 commit comments

Comments
 (0)