Skip to content

Commit 1da5216

Browse files
authored
Merge pull request #1897 from reduxjs/bugfix/v8-merge-dispatchprop
2 parents 80fc518 + 7765805 commit 1da5216

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/components/connect.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ export interface Connect<DefaultState = unknown> {
312312
<no_state = {}, no_dispatch = {}, TOwnProps = {}, TMergedProps = {}>(
313313
mapStateToProps: null | undefined,
314314
mapDispatchToProps: null | undefined,
315-
mergeProps: MergeProps<undefined, undefined, TOwnProps, TMergedProps>
315+
mergeProps: MergeProps<undefined, DispatchProp, TOwnProps, TMergedProps>
316316
): InferableComponentEnhancerWithProps<TMergedProps, TOwnProps>
317317

318318
/** mapState and mergeProps */
@@ -325,7 +325,7 @@ export interface Connect<DefaultState = unknown> {
325325
>(
326326
mapStateToProps: MapStateToPropsParam<TStateProps, TOwnProps, State>,
327327
mapDispatchToProps: null | undefined,
328-
mergeProps: MergeProps<TStateProps, undefined, TOwnProps, TMergedProps>
328+
mergeProps: MergeProps<TStateProps, DispatchProp, TOwnProps, TMergedProps>
329329
): InferableComponentEnhancerWithProps<TMergedProps, TOwnProps>
330330

331331
/** mapDispatch (as a object) and mergeProps */

test/typetests/connect-options-and-issues.tsx

+8
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,14 @@ function TestMergedPropsInference() {
103103
merged: 'merged',
104104
})
105105
)(MergedPropsComponent)
106+
107+
const ConnectedWithInferredDispatch = connect(
108+
mapStateToProps,
109+
undefined,
110+
(stateProps, dispatchProps, ownProps) => {
111+
expectType<DispatchProp<AnyAction>>(dispatchProps)
112+
}
113+
)(MergedPropsComponent)
106114
}
107115

108116
function Issue16652() {

0 commit comments

Comments
 (0)