Clean up lint process so that Lerna runs lint on all packages and eslint is the standard. Incorporate the React ESlint rules as well.

Author: drewpc

.eslintrc

@@ -19,6 +19,10 @@
   "plugins": [
     "react"
   ],
+  "extends": [
+    "eslint:recommended",
+    "plugin:react/recommended"
+  ],
   "rules": {
     "react/jsx-uses-vars": 2,
     "camelcase": 0,
@@ -59,6 +63,7 @@
       "except-parens"
     ],
     "no-constant-condition": 2,
+    "no-console": 1,
     "no-dupe-args": 2,
     "no-dupe-keys": 2,
     "no-empty": 2,
@@ -98,6 +103,7 @@
       "double"
     ],
     "react/jsx-uses-react": 2,
+    "react/react-in-jsx-scope": 1, // make this a warning for now, until things can be refactored
     "semi": [
       0,
       "always"

packages/babel-plugin-react-server/package.json

@@ -10,7 +10,7 @@
   },
   "scripts": {
     "clean": "rm -rf lib npm-debug.log*",
-    "lint": "eslint src/ test/index.js",
+    "lint": "eslint src test/index.js",
     "build": "../../node_modules/.bin/babel --root-mode upward src -d lib",
     "test": "mocha --compilers js:babel-register",
     "test:watch": "npm run test -- --watch",

packages/babel-preset-react-server/.eslintignore

@@ -0,0 +1 @@
+tst

packages/babel-preset-react-server/index.js

@@ -1,11 +1,11 @@
 module.exports = {
-  plugins: [
-    require('babel-plugin-react-server'),
-    require('babel-plugin-transform-runtime'),
-  ],
-  presets: [
-    require('babel-preset-es2015'),
-    require('babel-preset-react'),
-    require('babel-preset-stage-0'),
-  ],
-}
+	plugins: [
+		require('babel-plugin-react-server'),
+		require('babel-plugin-transform-runtime'),
+	],
+	presets: [
+		require('babel-preset-es2015'),
+		require('babel-preset-react'),
+		require('babel-preset-stage-0'),
+	],
+};

packages/babel-preset-react-server/package.json

@@ -5,6 +5,7 @@
   "main": "index.js",
   "scripts": {
     "clean": "rimraf npm-debug.log*",
+    "lint": "eslint .",
     "prepublish": "npm run clean"
   },
   "repository": "redfin/react-server",

packages/babel-preset-react-server/test.js

@@ -7,7 +7,7 @@ test('module can be required', t => {
 		require('.');
 		t.pass();
 	} catch (e) {
-		console.error(e);
+		console.error(e); //eslint-disable-line no-console
 		t.fail();
 	}
 });
@@ -23,7 +23,7 @@ function readFile(filename) {
 	return new Promise((resolve, reject) => {
 		fs.readFile(filename, (err, data) => {
 			if (err) {
-				console.error(err);
+				console.error(err); //eslint-disable-line no-console
 				reject(err);
 			} else {
 				resolve(data.toString());
@@ -33,5 +33,5 @@ function readFile(filename) {
 }
 
 function trim(str) {
-  return str.replace(/^\s+|\s+$/, '');
+	return str.replace(/^\s+|\s+$/, '');
 }

packages/flab/.eslintignore

@@ -0,0 +1,2 @@
+string
+LAB.src.js

packages/flab/minify.js

@@ -1,4 +1,4 @@
-require("get-stdin")().then(src => console.log(
+require("get-stdin")().then(src => console.log( // eslint-disable-line no-console
 	"\n"+
 	"/*! LAB.js (LABjs :: Loading And Blocking JavaScript)\n"+
 	"    v2.0.3 (c) Kyle Simpson\n"+

packages/flab/package.json

@@ -13,6 +13,7 @@
     "build-src": "node stringify.js < LAB.src.js > string/src.js",
     "build-min": "node minify.js < LAB.src.js | node stringify.js > string/min.js",
     "clean": "rimraf string",
+    "lint": "eslint .",
     "test": "echo \"No tests yet...\""
   },
   "repository": {

packages/flab/stringify.js

@@ -1,4 +1,4 @@
-require("get-stdin")().then(src => console.log(
+require("get-stdin")().then(src => console.log( // eslint-disable-line no-console
 	'module.exports = ' + src
 		.replace(/\\/g, '\\\\')
 		.replace(/"/g, '\\"')

packages/react-server-cli/gulpfile.babel.js

@@ -1,4 +1,3 @@
-import eslint from "gulp-eslint";
 import gulp from "gulp";
 import babel from "gulp-babel";
 import changed from "gulp-changed";
@@ -14,20 +13,7 @@ gulp.task("default", () => {
 		.pipe(gulp.dest(dest));
 });
 
-gulp.task("eslint", [], () => {
-	return gulp.src("src/**/*.js")
-	// eslint() attaches the lint output to the eslint property
-	// of the file object so it can be used by other modules.
-	.pipe(eslint())
-	// eslint.format() outputs the lint results to the console.
-	// Alternatively use eslint.formatEach() (see Docs).
-	.pipe(eslint.format())
-	// To have the process exit with an error code (1) on
-	// lint error, return the stream and pipe to failOnError last.
-	.pipe(eslint.failAfterError());
-});
-
-gulp.task("test", ["default", "eslint"], () => {
+gulp.task("test", ["default"], () => {
 	return gulp.src("target/__tests__/**/*[Ss]pec.js")
 		.pipe(jasmine({}));
 });

packages/react-server-cli/package.json

@@ -7,7 +7,7 @@
     "ava-watch": "ava --watch",
     "build": "gulp",
     "clean": "rimraf target npm-debug.log*",
-    "lint": "gulp eslint",
+    "lint": "eslint src test",
     "prepublish": "npm run build",
     "test": "ava && gulp test",
     "watch": "gulp && gulp watch"

packages/react-server-cli/test/fixtures/commands/start-reactserverrc/in-files/customRoutes.js

@@ -1,3 +1,3 @@
 module.exports = {
-	routes: {}
+	routes: {},
 };

packages/react-server-cli/test/fixtures/commands/start-routes-with-error/in-files/routes.js

@@ -1 +1 @@
-undeclaredVariable();
+undeclaredVariable(); // eslint-disable-line no-undef