DPO notebook: colab pkg missing

[d-kleine]

Bug description

As google.colab will be imported for the use of the colab GPU:

LLMs-from-scratch/ch07/04_preference-tuning-with-dpo/dpo-from-scratch.ipynb

Line 1584 in c278745

" from google.colab import drive\n",

I think it might be useful to add colab to the package installation at the every top of the notebook

What operating system are you using?

None

Where do you run your code?

None

Environment

[rasbt]

Unless I am missing something, it is only conditionally executed (for a subset of users who use Colab) via:

    # If this notebook is run on Google Colab, get it from a Google Drive folder
    elif "COLAB_GPU" in os.environ or "COLAB_TPU_ADDR" in os.environ:
        from google.colab import drive
        drive.mount("/content/drive")
        google_drive_path = "/content/drive/My Drive/Books/LLMs-From-Scratch/ch07/colab/gpt2-medium355M-sft.pth"  # Readers need to adjust this path
        shutil.copy(google_drive_path, ".")

but then if it is executed in a Google Colab notebook, the google.colab library should already be pre-installed there, so I don't think it's necessary to add this to the installation. Otherwise, people might think they have to install it themselves. Any thoughts?

[d-kleine]

Ah, I see – yeah, you are right! All good then! 🙂