Fix global namespaced package detection with bun + add automatic package manager detection for ncu -g (#1514)

Author: LuisFerLCC

.ncurc.js

@@ -5,6 +5,7 @@ module.exports = {
     // https://github.com/tj/commander.js/pull/2312
     'commander',
     // breaking
+    '@types/bun',
     '@types/chai-as-promised',
     '@types/node',
     'chai-as-promised',

package-lock.json

@@ -58,6 +58,7 @@
   },
   "devDependencies": {
     "@trivago/prettier-plugin-sort-imports": "^5.2.2",
+    "@types/bun": "^1.2.10",
     "@types/chai": "^4.3.19",
     "@types/chai-as-promised": "^8.0.0",
     "@types/chai-string": "^1.4.5",

package.json

@@ -13,6 +13,22 @@ const packageManagerLockfileMap: Index<PackageManagerName> = {
   bun: 'bun',
 }
 
+/**
+ * Get the package manager being used to run the command.
+ * When checking global packages, we need to do it this way since there is no
+ * lockfile in the global directory.
+ */
+const getRunningPackageManager = (): PackageManagerName => {
+  const userAgent = process.env.npm_config_user_agent ?? ''
+  const execpath = process.env.npm_execpath ?? ''
+
+  if (userAgent.startsWith('yarn/') || execpath.includes('yarn')) return 'yarn'
+  if (userAgent.startsWith('pnpm/') || execpath.includes('pnpm')) return 'pnpm'
+  if (userAgent.startsWith('bun/') || typeof Bun !== 'undefined' || process.versions.bun) return 'bun'
+
+  return 'npm'
+}
+
 /**
  * If the packageManager option was not provided, look at the lockfiles to
  * determine which package manager is being used.
@@ -23,7 +39,7 @@ const determinePackageManager = async (
   readdir: (_path: string) => Promise<string[]> = fs.readdir,
 ): Promise<PackageManagerName> => {
   if (options.packageManager) return options.packageManager
-  else if (options.global) return 'npm'
+  else if (options.global) return getRunningPackageManager()
 
   const lockfileName = (await findLockfile(options, readdir))?.filename
   return lockfileName ? packageManagerLockfileMap[lockfileName.split('.')[0]] : 'npm'

src/lib/determinePackageManager.ts

@@ -60,7 +60,8 @@ export const list = async (options: Options = {}): Promise<Index<string | undefi
   // When bun is spawned in the GitHub Actions environment, it outputs ANSI color. Unfortunately, it does not respect the `NO_COLOR` envirionment variable. Therefore, we have to manually strip ansi.
   const lines = stripAnsi(stdout).split('\n')
   const dependencies = keyValueBy(lines, line => {
-    const match = line.match(/.* (.*?)@(.+)/)
+    // The capturing group for the package name requires a + quantifier, otherwise namespaced packages like @angular/cli will not be captured correctly.
+    const match = line.match(/.* (.+?)@(.+)/)
     if (match) {
       const [, name, version] = match
       return { [name]: version }

src/package-managers/bun.ts

@@ -164,4 +164,72 @@ describe('determinePackageManager', () => {
     )
     packageManager.should.equal('npm')
   })
+
+  describe('global', () => {
+    it('detects npm', async () => {
+      const oldUserAgent = process.env.npm_config_user_agent
+      const oldExecpath = process.env.npm_execpath
+
+      process.env.npm_config_user_agent = 'bun/1.2.10'
+      process.env.npm_execpath = 'bun'
+      process.versions.bun = '1.2.10'
+
+      const packageManager = await determinePackageManager({
+        global: true,
+      })
+      packageManager.should.equal('bun')
+
+      process.env.npm_config_user_agent = oldUserAgent
+      process.env.npm_execpath = oldExecpath
+      process.versions.bun = ''
+    })
+
+    it('detects yarn', async () => {
+      const oldUserAgent = process.env.npm_config_user_agent
+      const oldExecpath = process.env.npm_execpath
+
+      process.env.npm_config_user_agent = 'yarn/1.2.10'
+      process.env.npm_execpath = 'yarn'
+
+      const packageManager = await determinePackageManager({
+        global: true,
+      })
+      packageManager.should.equal('yarn')
+
+      process.env.npm_config_user_agent = oldUserAgent
+      process.env.npm_execpath = oldExecpath
+    })
+
+    it('detects pnpm', async () => {
+      const oldUserAgent = process.env.npm_config_user_agent
+      const oldExecpath = process.env.npm_execpath
+
+      process.env.npm_config_user_agent = 'pnpm/1.2.10'
+      process.env.npm_execpath = 'pnpm'
+
+      const packageManager = await determinePackageManager({
+        global: true,
+      })
+      packageManager.should.equal('pnpm')
+
+      process.env.npm_config_user_agent = oldUserAgent
+      process.env.npm_execpath = oldExecpath
+    })
+
+    it('defaults to npm', async () => {
+      const oldUserAgent = process.env.npm_config_user_agent
+      const oldExecpath = process.env.npm_execpath
+
+      process.env.npm_config_user_agent = ''
+      process.env.npm_execpath = ''
+
+      const packageManager = await determinePackageManager({
+        global: true,
+      })
+      packageManager.should.equal('npm')
+
+      process.env.npm_config_user_agent = oldUserAgent
+      process.env.npm_execpath = oldExecpath
+    })
+  })
 })

test/bun/bun.lockb

@@ -0,0 +1,19 @@
+{
+  "lockfileVersion": 1,
+  "workspaces": {
+    "": {
+      "dependencies": {
+        "emitter20": "2.0.0",
+        "ncu-test-return-version": "~1.0.0",
+        "ncu-test-v2": "~2.0.0",
+      },
+    },
+  },
+  "packages": {
+    "emitter20": ["[email protected]", "", {}, "sha512-S6tIABrpAK6CJrZddTwMnLVWP4YUskGCW8jRtZ7OaA/Gdmm0Neg34RJGiUYWUq2RK2suvzZ5hFBg9350+CDuuA=="],
+
+    "ncu-test-return-version": ["[email protected]", "", {}, "sha512-xen4KcnzVAHxYIGDm1vyKJ6BOKGxATwrW7TMO9/Teg0IwQQ1EaiPi2lr16bqgPnT8odWcZHzdh4WiHsbCaMCqQ=="],
+
+    "ncu-test-v2": ["[email protected]", "", {}, "sha512-Jqu6DzpKkTrUdeL+VN/X4lz4IVDxkNAqVHmyJ+3uVcszqPlU8JMNTA2qeihzMcbd4pOiagKlJno7r+EO2WLmfw=="],
+  }
+}