Skip to content

Commit 6af39dc

Browse files
committed
fix: rollback nonce to string change
1 parent 8e99034 commit 6af39dc

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

packages/api-kit/tests/e2e/getTransaction.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ describe('getTransaction', () => {
3030
const transaction = await safeApiKit.getTransaction(safeTxHash)
3131
chai.expect(transaction.safeTxHash).to.be.equal(safeTxHash)
3232
chai.expect(transaction.safe).to.be.eq(API_TESTING_SAFE.address)
33-
chai.expect(transaction.nonce).to.be.a('string')
34-
chai.expect(transaction.safeTxGas).to.be.a('string')
35-
chai.expect(transaction.baseGas).to.be.a('string')
33+
chai.expect(transaction.nonce).to.be.a('number')
34+
chai.expect(transaction.safeTxGas).to.be.a('number')
35+
chai.expect(transaction.baseGas).to.be.a('number')
3636
})
3737
})

packages/protocol-kit/src/Safe.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,12 +1255,12 @@ class Safe {
12551255
operation: serviceTransactionResponse.operation
12561256
}
12571257
const options = {
1258-
safeTxGas: serviceTransactionResponse.safeTxGas,
1259-
baseGas: serviceTransactionResponse.baseGas,
1258+
safeTxGas: serviceTransactionResponse.safeTxGas.toString(),
1259+
baseGas: serviceTransactionResponse.baseGas.toString(),
12601260
gasPrice: serviceTransactionResponse.gasPrice,
12611261
gasToken: serviceTransactionResponse.gasToken,
12621262
refundReceiver: serviceTransactionResponse.refundReceiver,
1263-
nonce: Number(serviceTransactionResponse.nonce)
1263+
nonce: serviceTransactionResponse.nonce
12641264
}
12651265
const safeTransaction = await this.createTransaction({
12661266
transactions: [safeTransactionData],

packages/types-kit/src/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,11 @@ export type SafeMultisigTransactionResponse = {
232232
readonly data?: string
233233
readonly operation: number
234234
readonly gasToken: string
235-
readonly safeTxGas: string
236-
readonly baseGas: string
235+
readonly safeTxGas: number
236+
readonly baseGas: number
237237
readonly gasPrice: string
238238
readonly refundReceiver?: string
239-
readonly nonce: string
239+
readonly nonce: number
240240
readonly executionDate: string
241241
readonly submissionDate: string
242242
readonly modified: string

0 commit comments

Comments
 (0)