Skip to content

Bug: Stop using show.partials.insert #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jcoyne opened this issue Feb 6, 2025 · 0 comments · May be fixed by #3163 or #3429
Open

Bug: Stop using show.partials.insert #3430

jcoyne opened this issue Feb 6, 2025 · 0 comments · May be fixed by #3163 or #3429
Labels
bug

Comments

@jcoyne
Copy link
Member

jcoyne commented Feb 6, 2025 •
edited by hackartisan
Loading

Description

spotlight/spec/test_app_templates/catalog_controller.rb

Line 16 in c7e6517

config.show.partials.insert(1, :openseadragon)

Blackight 9 no longer has show.partials as part of its configuration.

Steps to reproduce

Expected behavior

Technical tips

This is how the code has injected the openseadragon viewer. The openseadragon code has been updated, is this still the right way?

If so, we should probably replace it with a component.
@jcoyne jcoyne added the bug label Feb 6, 2025
@corylown corylown linked a pull request Feb 12, 2025 that will close this issue
Open
@jcoyne jcoyne linked a pull request Apr 16, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Spotlight Community Sprint 2025
Status: No status
Milestone
No milestone
1 participant
@jcoyne