You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FES is a core part of making p5.js approachable, but it is currently disabled in p5.strands
Most appropriate sub-area of p5.js?
Accessibility
Color
Core/Environment/Rendering
Data
DOM
Events
Image
IO
Math
Typography
Utilities
WebGL
Build process
Unit testing
Internationalization
Friendly errors
Other (specify if possible)
Feature enhancement details
p5.strands disables FES entirely whilst it compiles the user's code to GLSL. This is because there are some functions with shared scope and name clashes, in p5.strands and the core p5.js library... see #7849. This causes two types of false negatives, to my knowledge:
FES prints a lot of warnings about overriding p5.js variables.
FES will also give warnings coming from _validateParameters, since it expects the core function signature. For example, if you use sin(10) in strands, it will be converted to sin(dynamicNode(10)), and the actual received arg will not be of type Number. FES will therefore warn that sin expects a number. This is also the case for atan() which GLSL allows 1 or 2 arguments for, whereas p5.js only allows one.
The text was updated successfully, but these errors were encountered:
Increasing access
FES is a core part of making p5.js approachable, but it is currently disabled in p5.strands
Most appropriate sub-area of p5.js?
Feature enhancement details
p5.strands disables FES entirely whilst it compiles the user's code to GLSL. This is because there are some functions with shared scope and name clashes, in p5.strands and the core p5.js library... see #7849. This causes two types of false negatives, to my knowledge:
_validateParameters
, since it expects the core function signature. For example, if you usesin(10)
in strands, it will be converted tosin(dynamicNode(10))
, and the actual received arg will not be of type Number. FES will therefore warn thatsin
expects a number. This is also the case foratan()
which GLSL allows 1 or 2 arguments for, whereas p5.js only allows one.The text was updated successfully, but these errors were encountered: