Skip to content

Commit 4266174

Browse files
Shadow improvements for resting shadows (#1187)
* update buttons * Update resting shadows * improve resting med
1 parent 9802c5b commit 4266174

File tree

3 files changed

+52
-14
lines changed

3 files changed

+52
-14
lines changed

.changeset/tasty-games-love.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/primitives': patch
3+
---
4+
5+
Update resting shadow values

src/tokens/component/button.json5

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@
136136
},
137137
},
138138
},
139-
shadow: {
139+
shadow: {
140140
resting: {
141141
$value: [
142142
{
@@ -479,7 +479,7 @@
479479
},
480480
},
481481
},
482-
shadow: {
482+
shadow: {
483483
selected: {
484484
$value: [
485485
{
@@ -982,7 +982,7 @@
982982
},
983983
},
984984
},
985-
shadow: {
985+
shadow: {
986986
selected: {
987987
$value: [
988988
{
@@ -1289,7 +1289,7 @@
12891289
},
12901290
},
12911291
},
1292-
shadow: {
1292+
shadow: {
12931293
selected: {
12941294
$value: [
12951295
{

src/tokens/functional/shadow/shadow.json5

Lines changed: 43 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@
3535
xsmall: {
3636
$value: {
3737
color: '{base.color.neutral.13}',
38-
alpha: 0.1,
38+
alpha: 0.06,
3939
offsetX: '0px',
4040
offsetY: '1px',
41-
blur: '0px',
41+
blur: '1px',
4242
spread: '0px',
4343
inset: false,
4444
},
@@ -55,7 +55,7 @@
5555
alpha: 0.8,
5656
offsetX: '0px',
5757
offsetY: '1px',
58-
blur: '0px',
58+
blur: '1px',
5959
spread: '0px',
6060
inset: false,
6161
},
@@ -67,10 +67,19 @@
6767
$value: [
6868
{
6969
color: '{base.color.neutral.13}',
70-
alpha: 0.04,
70+
alpha: 0.06,
7171
offsetX: '0px',
7272
offsetY: '1px',
73-
blur: '0px',
73+
blur: '1px',
74+
spread: '0px',
75+
inset: false,
76+
},
77+
{
78+
color: '{base.color.neutral.13}',
79+
alpha: 0.06,
80+
offsetX: '0px',
81+
offsetY: '1px',
82+
blur: '3px',
7483
spread: '0px',
7584
inset: false,
7685
},
@@ -86,10 +95,19 @@
8695
$value: [
8796
{
8897
color: '{base.color.neutral.0}',
89-
alpha: 0.4,
98+
alpha: 0.6,
9099
offsetX: '0px',
91100
offsetY: '1px',
92-
blur: '0px',
101+
blur: '1px',
102+
spread: '0px',
103+
inset: false,
104+
},
105+
{
106+
color: '{base.color.neutral.0}',
107+
alpha: 0.6,
108+
offsetX: '0px',
109+
offsetY: '1px',
110+
blur: '3px',
93111
spread: '0px',
94112
inset: false,
95113
},
@@ -100,6 +118,14 @@
100118
},
101119
medium: {
102120
$value: [
121+
{
122+
color: '{base.color.neutral.12}',
123+
alpha: 0.1,
124+
offsetX: '0px',
125+
offsetY: '1px',
126+
blur: '1px',
127+
spread: '0px',
128+
},
103129
{
104130
color: '{base.color.neutral.12}',
105131
alpha: 0.12,
@@ -118,6 +144,14 @@
118144
'org.primer.overrides': {
119145
dark: {
120146
$value: [
147+
{
148+
color: '{base.color.neutral.0}',
149+
alpha: 0.4,
150+
offsetX: '0px',
151+
offsetY: '1px',
152+
blur: '1px',
153+
spread: '0px',
154+
},
121155
{
122156
color: '{base.color.neutral.0}',
123157
alpha: 0.8,
@@ -414,8 +448,7 @@
414448
],
415449
$type: 'shadow',
416450
$extensions: {
417-
'org.primer.figma': {
418-
},
451+
'org.primer.figma': {},
419452
'org.primer.overrides': {
420453
dark: {
421454
$value: [
@@ -442,4 +475,4 @@
442475
},
443476
},
444477
},
445-
}
478+
}

0 commit comments

Comments
 (0)