convert array of font families to string for figma (#901)

Author: lukasoppermann

src/transformers/fontFamilyToCss.ts

@@ -1,8 +1,7 @@
 import type StyleDictionary from 'style-dictionary'
 import {isFontFamily} from '../filters'
 import {getTokenValue} from './utilities/getTokenValue'
-
-const hasSpaceInName = (string: string) => /\s/g.test(string)
+import {hasSpaceInString} from './utilities/hasSpaceInString'
 /**
  * takes a value and returns it if its a string or concats strings in an array quoting strings with spaces
  * @param value
@@ -18,7 +17,7 @@ export const parseFontFamily = (value: unknown): string => {
         if (typeof string !== 'string') {
           throw new Error(`Invalid value in array ${string}, must be a string`)
         }
-        return hasSpaceInName(string) ? `'${string}'` : string
+        return hasSpaceInString(string) ? `'${string}'` : string
       })
       .join(', ')
   }

src/transformers/fontFamilyToFigma.test.ts

@@ -15,7 +15,7 @@ describe('Transformer: fontFamilyToFigma', () => {
     expect(input.map(item => fontFamilyToFigma.transformer(item, {}))).toStrictEqual(expectedOutput)
   })
 
-  it.skip('transforms fontFamily array', () => {
+  it('transforms fontFamily array', () => {
     const input = [
       getMockToken({
         value: ['Roboto', 'Noto Sans'],

src/transformers/fontFamilyToFigma.ts

@@ -1,5 +1,6 @@
 import type StyleDictionary from 'style-dictionary'
 import {isFontFamily} from '../filters'
+import {hasSpaceInString} from './utilities/hasSpaceInString'
 /**
  * takes a value and returns it if its a string or concats strings in an array quoting strings with spaces
  * @param value
@@ -17,6 +18,17 @@ export const parseFontFamily = (
   if (typeof token.value === 'string') {
     return token.value
   }
+  // return stringified array
+  if (Array.isArray(token.value)) {
+    return token.value
+      .map((string: string) => {
+        if (typeof string !== 'string') {
+          throw new Error(`Invalid value in array ${string}, must be a string`)
+        }
+        return hasSpaceInString(string) ? `'${string}'` : string
+      })
+      .join(', ')
+  }
   // invalid value
   throw new Error(`Invalid value ${token.value}, should be a string or array of strings`)
 }

src/transformers/utilities/hasSpaceInString.test.ts

@@ -0,0 +1,28 @@
+import {hasSpaceInString} from './hasSpaceInString'
+
+describe('Utilities: hasSpaceInString', () => {
+  it('returns true if string has space', () => {
+    expect(hasSpaceInString('string with space')).toBe(true)
+  })
+
+  it('returns false if string has no space', () => {
+    expect(hasSpaceInString('string-without-space')).toBe(false)
+  })
+
+  it('throws a typeError if invalid input is used', () => {
+    expect(() => {
+      // @ts-expect-error due to testing wrong input
+      hasSpaceInString(100)
+    }).toThrow(TypeError)
+
+    expect(() => {
+      // @ts-expect-error due to testing wrong input
+      hasSpaceInString(['string'])
+    }).toThrow(TypeError)
+
+    expect(() => {
+      // @ts-expect-error due to testing wrong input
+      hasSpaceInString({value: 'string'})
+    }).toThrow(TypeError)
+  })
+})

src/transformers/utilities/hasSpaceInString.ts

@@ -0,0 +1,6 @@
+export const hasSpaceInString = (string: string): boolean => {
+  if (typeof string !== 'string') {
+    throw new TypeError(`Invalid input. Input must be a string, ${typeof string} provided`)
+  }
+  return /\s/g.test(string)
+}