Skip to content

Add compact to fmt_currency #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
gartinian opened this issue Mar 26, 2025 · 1 comment · May be fixed by #664
Open
2 tasks done

Add compact to fmt_currency #649

gartinian opened this issue Mar 26, 2025 · 1 comment · May be fixed by #664

Comments

@gartinian
Copy link

Prework

Proposal

Add the compact parameter to fmt_currency, so that values such as $12,345 can render as $12K. The intention is to mirror the behavior of compact in other formatters, such as fmt_integer.

I have reviewed the code and believe I know where changes should be made. I am happy to submit a PR if there is alignment on moving forward.

@rich-iannone
Copy link
Member

This is definitely an unintentional omission. We’d be happy to accept a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants