Skip to content

Normalize addresses before sending #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brancz opened this issue Mar 3, 2025 · 0 comments
Open

Normalize addresses before sending #24

brancz opened this issue Mar 3, 2025 · 0 comments

Comments

@brancz
Copy link
Member

brancz commented Mar 3, 2025

We currently do something fairly odd, which is that we add a non-standard comment into the pprof message. We do this in order to perform server-side normalization of addresses. However, pprof actually has a mechanism to signal that addresses have already been adjusted to be machine independent, by setting mapping start, length and offset to 0.

What does that mean? If we set mapping start, length, and offset to 0, and adjust the address (addr - (start - offset)) on the client already, then we both maintain support with pprof tooling and can get rid of the non-standard comment.

@umanwizard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant