Skip to content

Proposal: Move the project to version 1.0.0? #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damien-louis opened this issue Feb 14, 2025 · 2 comments
Open

Proposal: Move the project to version 1.0.0? #452

damien-louis opened this issue Feb 14, 2025 · 2 comments

Comments

@damien-louis
Copy link

What do you think about moving to version 1.0.0, given that the project seems mature enough to be considered stable?

@AlessandroMinoccheri
Copy link
Member

Hi @damien-louis this is a discussion that we had different times, I think that it could be a good moment.
What do you think @fain182 @micheleorselli ?

@micheleorselli
Copy link
Member

these are the things I would double check before moving to version 1.0. I'm not saying we have to implement/change anything, but I would like to talk about it

  • collect information regarding traits and methods to have rules like HasTrait and HasMethod, does it make sense to do it?
  • are there any outstanding bugs or missing feature for the parser ie things the parser is not collecting?
  • should we rely on the project autoload in the rules? this would open the possibility to use native php function like is_a and so on
  • review rule structure: as of now we pass a violation collection inside the rule then it is the rule responsibility to add violation to it. should we move this responsibility outside of the rule?
  • rule names: there are some inconsistencies in the way rules are named: Have/Has Is/Are. Should we uniform the naming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants