Skip to content

Commit e7bbb65

Browse files
committed
Fix NPE in --version
1 parent 9f34ec0 commit e7bbb65

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

graalpython/com.oracle.graal.python.shell/src/com/oracle/graal/python/shell/GraalPythonMain.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ protected void launch(Builder contextBuilder) {
848848
rc = readEvalPrint(context, consoleHandler);
849849
}
850850
} catch (RuntimeException e) {
851-
if (e.getMessage().contains("did not complete all polyglot threads")) {
851+
if (e.getMessage() != null && e.getMessage().contains("did not complete all polyglot threads")) {
852852
// Python may end up with stuck threads and code would legitimately expect those to
853853
// simply die with the process. In an embedding (or CPython subinterpreters) this
854854
// is a problem, so Truffle throws an IllegalStateException when closing the

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_cmd_line.txt

+1
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ test.test_cmd_line.CmdLineTest.test_unbuffered_input @ darwin-arm64,darwin-x86_6
2121
test.test_cmd_line.CmdLineTest.test_unbuffered_output @ darwin-arm64,darwin-x86_64,linux-aarch64,linux-x86_64,win32-AMD64
2222
test.test_cmd_line.CmdLineTest.test_unmached_quote @ darwin-arm64,darwin-x86_64,linux-aarch64,linux-x86_64,win32-AMD64
2323
test.test_cmd_line.CmdLineTest.test_verbose @ darwin-arm64,darwin-x86_64,linux-aarch64,linux-x86_64,win32-AMD64
24+
test.test_cmd_line.CmdLineTest.test_version @ linux-x86_64
2425
test.test_cmd_line.IgnoreEnvironmentTest.test_ignore_PYTHONPATH @ darwin-arm64,darwin-x86_64,linux-aarch64,linux-x86_64,win32-AMD64

graalpython/lib-python/3/test/test_cmd_line.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ def test_site_flag(self):
7878
self.verify_valid_flag('-S')
7979

8080
def test_version(self):
81-
version = ('Python %d.%d' % sys.version_info[:2]).encode("ascii")
81+
# GraalPy change: expect GraalPy name
82+
version = ('GraalPy %d.%d' % sys.version_info[:2]).encode("ascii")
8283
for switch in '-V', '--version', '-VV':
8384
rc, out, err = assert_python_ok(switch)
8485
self.assertFalse(err.startswith(version))

0 commit comments

Comments
 (0)