Fixed specs failing due to course_member method and added specs for it

Author: Dantemss

lib/openstax/biglearn/api/real_client.rb

@@ -376,11 +376,11 @@ def create_update_assignments(requests)
 
     biglearn_requests = requests.map do |request|
       task = request.fetch(:task)
+      student = task.taskings.first.try!(:role).try!(:course_member)
+      next if student.nil?
+
       ecosystem = task.ecosystem
-      role = task.taskings.first.try!(:role)
-      next if role.nil?
 
-      student = role.course_member
       task_type = task.practice? ? 'practice' : task.task_type
 
       opens_at = task.opens_at
@@ -450,11 +450,15 @@ def create_update_assignments(requests)
   # Records the given student responses
   def record_responses(requests)
     biglearn_requests = requests.map do |request|
-      course = request.fetch(:course)
       tasked_exercise = request.fetch(:tasked_exercise)
       task = tasked_exercise.task_step.task
-      role = task.taskings.first.role
+      role = task.taskings.first.try!(:role)
+      next if role.nil?
+
       student = role.course_member
+      next if student.nil?
+
+      course = request.fetch(:course)
 
       {
         response_uuid: request.fetch(:response_uuid),
@@ -468,7 +472,7 @@ def record_responses(requests)
         is_real_response: !course.is_preview && !course.is_test && !role.teacher_student?,
         responded_at: tasked_exercise.updated_at.utc.iso8601(6)
       }
-    end
+    end.compact
 
     bulk_api_request(
       url: :record_responses,
@@ -484,9 +488,9 @@ def record_responses(requests)
   def fetch_assignment_pes(requests)
     biglearn_requests = requests.map do |request|
       task = request.fetch(:task)
-      role = task.taskings.first.role
-      student = role.course_member
-      course = student.course
+      course = task.taskings.first.try!(:role).try!(:course)
+      next if course.nil?
+
       max_num_exercises = request[:max_num_exercises]
       algorithm_name = course.biglearn_assignment_pes_algorithm_name ||
                        Settings::Biglearn.assignment_pes_algorithm_name.to_s
@@ -508,9 +512,9 @@ def fetch_assignment_pes(requests)
   def fetch_assignment_spes(requests)
     biglearn_requests = requests.map do |request|
       task = request.fetch(:task)
-      role = task.taskings.first.role
-      student = role.course_member
-      course = student.course
+      course = task.taskings.first.try!(:role).try!(:course)
+      next if course.nil?
+
       max_num_exercises = request[:max_num_exercises]
       algorithm_name = course.biglearn_assignment_spes_algorithm_name ||
                        Settings::Biglearn.assignment_spes_algorithm_name.to_s

spec/factories/tasks/tasked_task_plan.rb

@@ -57,13 +57,10 @@
 
     after(:build) do |task_plan, evaluator|
       course = task_plan.owner
-      period = course.periods.first ||
-               FactoryBot.create(:course_membership_period, course: course)
+      period = course.periods.first || FactoryBot.create(:course_membership_period, course: course)
 
       evaluator.number_of_students.times do
-        user = create :user
-        role = Role::GetDefaultUserRole[user]
-        CourseMembership::AddStudent.call(period: period, role: role)
+        AddUserAsPeriodStudent.call(user: create(:user), period: period)
       end
 
       task_plan.tasking_plans = [build(:tasks_tasking_plan, task_plan: task_plan, target: period)]

spec/models/entity/role_spec.rb

@@ -7,13 +7,18 @@
 
   it { is_expected.to have_one(:student).dependent(:destroy) }
   it { is_expected.to have_one(:teacher).dependent(:destroy) }
+  it { is_expected.to have_one(:teacher_student).dependent(:destroy) }
 
   it { is_expected.to belong_to(:profile) }
 
   [:username, :first_name, :last_name, :full_name, :name].each do |delegated_method|
     it { is_expected.to delegate_method(delegated_method).to(:profile) }
   end
 
+  [:course, :course_profile_course_id].each do |delegated_method|
+    it { is_expected.to delegate_method(delegated_method).to(:course_member) }
+  end
+
   it { is_expected.to validate_uniqueness_of(:research_identifier) }
 
   context 'research_identifier' do
@@ -39,4 +44,19 @@
       expect(enrollment.student.role.latest_enrollment_at).to eq enrollment.created_at
     end
   end
+
+  context 'course_member' do
+    it 'returns the course_member based on the role type' do
+      expect(role.course_member).to be_nil
+
+      student = FactoryBot.create(:course_membership_student)
+      expect(student.role.course_member).to eq student
+
+      teacher = FactoryBot.create(:course_membership_teacher)
+      expect(teacher.role.course_member).to eq teacher
+
+      teacher_student = FactoryBot.create(:course_membership_teacher_student)
+      expect(teacher_student.role.course_member).to eq teacher_student
+    end
+  end
 end

spec/subsystems/tasks/update_period_caches_spec.rb

@@ -274,6 +274,8 @@
         let(:queue) { :lowest_priority }
 
         it 'is called when a task_plan is published' do
+          @task_plan.tasks.delete_all
+
           expect(configured_job).to receive(:perform_later) do |period_ids:|
             expect(period_ids).to match_array(@task_plan.tasking_plans.map(&:target_id))
           end
@@ -353,6 +355,8 @@
         let(:queue) { :low_priority }
 
         it 'is called when a task_plan is published' do
+          @task_plan.tasks.delete_all
+
           expect(configured_job).to receive(:perform_later) do |period_ids:|
             expect(period_ids).to match_array(@task_plan.tasking_plans.map(&:target_id))
           end

spec/subsystems/tasks/update_task_caches_spec.rb

@@ -288,6 +288,8 @@
       end
 
       it 'is called when a task_plan is published' do
+        @task_plan.tasks.delete_all
+
         expect(configured_job).to receive(:perform_later) do |task_ids:, queue:|
           expect(task_ids).to match_array(@task_plan.tasks.pluck(:id))
           expect(queue).to eq queue.to_s
@@ -451,6 +453,8 @@
       end
 
       it 'is called when a task_plan is published' do
+        @task_plan.tasks.delete_all
+
         expect(configured_job).to receive(:perform_later) do |task_ids:, queue:|
           expect(task_ids).to match_array(@task_plan.tasks.pluck(:id))
           expect(queue).to eq queue.to_s