Merge pull request #1877 from openstax/fe_roles

Include period_id with roles

Author: Dantemss

app/models/entity/role.rb

@@ -11,7 +11,7 @@ class Role < IndestructibleRecord
     belongs_to :profile, subsystem: :user, inverse_of: :roles
 
     delegate :username, :first_name, :last_name, :full_name, :name, to: :profile, allow_nil: true
-    delegate :course, :course_profile_course_id, to: :course_member, allow_nil: true
+    delegate :course, :period, :course_profile_course_id, to: :course_member, allow_nil: true
 
     unique_token :research_identifier, mode: :hex, length: 4, prefix: 'r'
 

app/representers/api/v1/role_representer.rb

@@ -10,6 +10,13 @@ class RoleRepresenter < Roar::Decorator
              writeable: false,
              schema_info: { required: true }
 
+    property :period_id,
+             getter: ->(*) { teacher? ? nil : course_member.course_membership_period_id },
+             type: String,
+             readable: true,
+             writeable: false,
+             schema_info: { required: true }
+
     property :role_type,
              as: :type,
              type: String,
@@ -36,5 +43,6 @@ class RoleRepresenter < Roar::Decorator
              getter: ->(*) { DateTimeUtilities.to_api_s(latest_enrollment_at) },
              schema_info: { required: true }
 
+
   end
 end

spec/controllers/api/v1/courses_controller_spec.rb

@@ -83,6 +83,7 @@
             id: student_role.id.to_s,
             research_identifier: student_role.research_identifier,
             type: 'student',
+            period_id: @period.id.to_s,
             joined_at: DateTimeUtilities.to_api_s(student_role.created_at),
             latest_enrollment_at: DateTimeUtilities.to_api_s(student_role.latest_enrollment_at)
           ),
@@ -102,6 +103,7 @@
             {
               id: student_role.id.to_s,
               type: 'student',
+              period_id: @period.id.to_s,
               research_identifier: student_role.research_identifier,
               joined_at: DateTimeUtilities.to_api_s(student_role.created_at),
               latest_enrollment_at: DateTimeUtilities.to_api_s(student_role.latest_enrollment_at)
@@ -344,6 +346,7 @@
           roles: a_collection_containing_exactly(
             id: student_role.id.to_s,
             type: 'student',
+            period_id: @period.id.to_s,
             research_identifier: student_role.research_identifier,
             joined_at: DateTimeUtilities.to_api_s(student_role.created_at),
             latest_enrollment_at: DateTimeUtilities.to_api_s(student_role.latest_enrollment_at)
@@ -364,6 +367,7 @@
             {
               id: student_role.id.to_s,
               type: 'student',
+              period_id: @period.id.to_s,
               research_identifier: student_role.research_identifier,
               joined_at: DateTimeUtilities.to_api_s(student_role.created_at),
               latest_enrollment_at: DateTimeUtilities.to_api_s(student_role.latest_enrollment_at)

spec/representers/api/v1/bootstrap_data_representer_spec.rb

@@ -41,7 +41,10 @@
           base_url: a_string_starting_with('http'),
           product_uuid: secrets.openstax[:payments][:product_uuid]
         },
-        feature_flags: { is_payments_enabled: Settings::Payments.payments_enabled },
+        feature_flags: {
+          is_payments_enabled: Settings::Payments.payments_enabled,
+          teacher_student_enabled: Settings::Db[:teacher_student_enabled]
+        },
         ui_settings: {},
         flash: { alert: 'Nothing!' }
       }.deep_stringify_keys