Fix tests/get 100% coverage

Author: RoyEJohnson

test/helpers/future-memory-router.tsx

@@ -0,0 +1,9 @@
+import React from 'react';
+import {MemoryRouter} from 'react-router-dom';
+
+// @ts-expect-error does not exist on
+const {routerFuture} = global;
+
+export default function FutureMemoryRouter(props: Parameters<typeof MemoryRouter>[0]) {
+    return <MemoryRouter {...props} future={routerFuture} />;
+}

test/src/layouts/landing/footer.test.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 import userEvent from '@testing-library/user-event';
 import {render, screen, waitFor} from '@testing-library/preact';
 import {describe, it} from '@jest/globals';
-import { MemoryRouter } from 'react-router-dom';
+import MR from '~/../../test/helpers/future-memory-router';
 import { useContactDialog } from '~/layouts/landing/footer/flex';
 
 const user = userEvent.setup({advanceTimers: jest.advanceTimersByTime});
@@ -31,9 +31,9 @@ describe('flex landing footer', () => {
             ];
 
             render(
-                <MemoryRouter initialEntries={['']}>
+                <MR initialEntries={['']}>
                     <ShowContactDialog contactFormParams={contactFormParams} />
-                </MemoryRouter>
+                </MR>
             );
             expect(getIframe()).toBeNull();
             await user.click(await screen.findByText('Contact Us'));
@@ -48,5 +48,17 @@ describe('flex landing footer', () => {
             window.postMessage('CONTACT_FORM_SUBMITTED', '*');
             await waitFor(() => expect(getIframe()).toBeNull());
         });
+        it('handles undefined contactFormParams', async () => {
+            const getIframe = () => document.querySelector('iframe');
+
+            render(
+                <MR initialEntries={['']}>
+                    <ShowContactDialog />
+                </MR>
+            );
+            expect(getIframe()).toBeNull();
+            await user.click(await screen.findByText('Contact Us'));
+            expect(getIframe()?.src.endsWith('embedded/contact')).toBe(true);
+        });
     });
 });

test/src/pages/details/book-details-context.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 import LoaderPage from '~/components/jsx-helpers/loader-page';
 import ShellContextProvider from '../../../helpers/shell-context';
 import {DetailsContextProvider, ContextValues} from '~/pages/details/context';
-import {MemoryRouter} from 'react-router-dom';
+import MR from '~/../../test/helpers/future-memory-router';
 
 // Tamp down meaningless errors
 jest.mock('~/models/rex-release', () => jest.fn().mockReturnValue(Promise.resolve({
@@ -30,8 +30,8 @@ export default function BookDetailsLoader({slug, children}: React.PropsWithChild
     const absoluteSlug = `/${slug}`;
 
     return (
-        <MemoryRouter initialEntries={[absoluteSlug]}>
+        <MR initialEntries={[absoluteSlug]}>
             <LoaderPage slug={slug} Child={BookDetailsWithContext} doDocumentSetup props={{children}} />
-        </MemoryRouter>
+        </MR>
     );
 }

test/src/pages/details/get-this-title/get-this-title.test.tsx

@@ -75,14 +75,13 @@ describe('get-this-title', () => {
     it('opens give dialog for Webview', async () => {
         render(<GTTinContext />);
         const wvLink = await screen.findByText('View online');
-
         const closeRecommendedCallout = screen.getByRole('button', {
             name: 'close-popup'
         });
 
         await user.click(closeRecommendedCallout);
-
         await user.click(wvLink);
+
         expect(screen.getAllByRole('dialog')).toHaveLength(2);
         const trackingLink = await screen.findByRole('link', {
             name: 'Go to your book'
@@ -98,6 +97,20 @@ describe('get-this-title', () => {
         expect(mockTrackLink).toHaveBeenCalled();
         mockTrackLink.mockReset();
     });
+    it('renders pluralized expander', async () => {
+        const extraLinksModel = {
+            ...baseModel,
+            assignableLink: 'the-assignable-version',
+            bookshareLink: 'the-bookshare-version'
+        };
+
+        render(<GTTinContext model={extraLinksModel} />);
+        const expander = await screen.findByText('+ 2 more options...');
+
+        await user.click(expander);
+        screen.getByRole('link', {name: 'Bookshare'});
+        screen.getByRole('link', {name: 'Download for Kindle'});
+    });
     it('opens give dialog for PDF', async () => {
         render(<GTTinContext />);
         const pdfLink = await screen.findByText('Download a PDF');