CARRY: Enable validation webhooks

Author: astefanutti

cmd/training-operator.v1/main.go

@@ -53,7 +53,7 @@ const (
 	// EnvKubeflowNamespace is an environment variable for namespace when deployed on kubernetes
 	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
 
-	webhookConfigurationName = "validator.training-operator.kubeflow.org"
+	webhookConfigurationName = "kubeflow-validator.training-operator.kubeflow.org"
 )
 
 var (

manifests/base/webhook/patch.yaml

@@ -1,18 +1,18 @@
 - op: replace
   path: /webhooks/0/clientConfig/service/name
-  value: training-operator
+  value: kubeflow-training-operator
 - op: replace
   path: /webhooks/1/clientConfig/service/name
-  value: training-operator
+  value: kubeflow-training-operator
 - op: replace
   path: /webhooks/2/clientConfig/service/name
-  value: training-operator
+  value: kubeflow-training-operator
 - op: replace
   path: /webhooks/3/clientConfig/service/name
-  value: training-operator
+  value: kubeflow-training-operator
 - op: replace
   path: /webhooks/4/clientConfig/service/name
-  value: training-operator
+  value: kubeflow-training-operator
 - op: replace
   path: /metadata/name
   value: validator.training-operator.kubeflow.org

manifests/rhoai/kustomization.yaml

@@ -44,9 +44,21 @@ resources:
 - kubeflow-training-roles.yaml
 - monitor.yaml
 
+secretGenerator:
+  - name: training-operator-webhook-cert
+    options:
+      disableNameSuffixHash: true
+
 patches:
 # Mount the controller config file for loading manager configurations
 # through a ComponentConfig type
 - path: manager_config_patch.yaml
 - path: manager_metrics_patch.yaml
-- path: manager_delete_metrics_service_patch.yaml
+- patch: |-
+    - op: remove
+      path: /spec/ports/0
+  target:
+    group: ""
+    version: v1
+    kind: Service
+    name: training-operator

manifests/rhoai/manager_config_patch.yaml

@@ -12,3 +12,12 @@ spec:
         - "--zap-log-level=2"
         - --pytorch-init-container-image
         - $(image)
+        - "--webhook-secret-name"
+        - "kubeflow-training-operator-webhook-cert"
+        - "--webhook-service-name"
+        - "kubeflow-training-operator"
+      volumes:
+      - name: cert
+        secret:
+          defaultMode: 420
+          secretName: kubeflow-training-operator-webhook-cert