Skip to content

Commit da4f55b

Browse files
fix: check if dependencies & devDependencies exist before deleting dep (#30224)
## Current Behavior `removeDependenciesFromPackageJson` tries to delete dep from `undefined` if there is no `dependencies` or `devDependencies` in package.json ## Expected Behavior First check if `dependencies` or `devDependencies` exists ## Related Issue(s) Fixes #30222 Co-authored-by: Jason Jean <[email protected]>
1 parent bde7315 commit da4f55b

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

packages/devkit/src/utils/package-json.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -287,15 +287,18 @@ export function removeDependenciesFromPackageJson(
287287
)
288288
) {
289289
updateJson(tree, packageJsonPath, (json) => {
290-
for (const dep of dependencies) {
291-
delete json.dependencies[dep];
290+
if (json.dependencies) {
291+
for (const dep of dependencies) {
292+
delete json.dependencies[dep];
293+
}
294+
json.dependencies = sortObjectByKeys(json.dependencies);
292295
}
293-
for (const devDep of devDependencies) {
294-
delete json.devDependencies[devDep];
296+
if (json.devDependencies) {
297+
for (const devDep of devDependencies) {
298+
delete json.devDependencies[devDep];
299+
}
300+
json.devDependencies = sortObjectByKeys(json.devDependencies);
295301
}
296-
json.dependencies = sortObjectByKeys(json.dependencies);
297-
json.devDependencies = sortObjectByKeys(json.devDependencies);
298-
299302
return json;
300303
});
301304
}

0 commit comments

Comments
 (0)