Skip to content

Commit 6bfd678

Browse files
authored
Merge pull request #1969 from mackler/fix-error-bars
Fix broken error bars in horizontal bar charts.
2 parents f78139d + 7969397 commit 6bfd678

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/models/multiBarHorizontal.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,13 +208,13 @@ nv.models.multiBarHorizontal = function() {
208208
var xerr = getYerr(d,i)
209209
, mid = 0.8 * x.rangeBand() / ((stacked ? 1 : data.length) * 2);
210210
xerr = xerr.length ? xerr : [-Math.abs(xerr), Math.abs(xerr)];
211-
xerr = xerr.map(function(e) { return y(e) - y(0); });
211+
xerr = xerr.map(function(e) { return y(e + ((getY(d,i) < 0) ? 0 : getY(d,i))) - y(0); });
212212
var a = [[xerr[0],-mid], [xerr[0],mid], [xerr[0],0], [xerr[1],0], [xerr[1],-mid], [xerr[1],mid]];
213213
return a.map(function (path) { return path.join(',') }).join(' ');
214214
})
215215
.attr('transform', function(d,i) {
216216
var mid = x.rangeBand() / ((stacked ? 1 : data.length) * 2);
217-
return 'translate(' + (getY(d,i) < 0 ? 0 : y(getY(d,i)) - y(0)) + ', ' + mid + ')'
217+
return 'translate(0, ' + mid + ')';
218218
});
219219
}
220220

0 commit comments

Comments
 (0)