fail fast also in bucketspace_fs

Signed-off-by: shirady <[email protected]>

Author: shirady

src/sdk/bucketspace_fs.js

@@ -813,9 +813,10 @@ class BucketSpaceFS extends BucketSpaceSimpleFS {
             `arn:aws:s3:::${bucket.name.unwrap()}${bucket_path}`,
             undefined
         );
+        if (permission_by_id === "DENY") return false;
         // we (currently) allow account identified to be both id and name,
         // so if by-id failed, try also name
-        if (account.owner === undefined && permission_by_id !== 'DENY') {
+        if (account.owner === undefined) {
             permission_by_name = await bucket_policy_utils.has_bucket_policy_permission(
                 bucket_policy,
                 account.name.unwrap(),
@@ -824,8 +825,7 @@ class BucketSpaceFS extends BucketSpaceSimpleFS {
                 undefined
             );
         }
-
-        if (permission_by_id === 'DENY' || permission_by_name === 'DENY') return false;
+        if (permission_by_name === 'DENY') return false;
         return is_owner || (permission_by_id === 'ALLOW' || permission_by_name === 'ALLOW');
     }